Skip to content

feat(gax): new type to represent credential errors#1688

Merged
coryan merged 5 commits intogoogleapis:mainfrom
coryan:feat-gax-new-error-for-credentials
Apr 2, 2025
Merged

feat(gax): new type to represent credential errors#1688
coryan merged 5 commits intogoogleapis:mainfrom
coryan:feat-gax-new-error-for-credentials

Conversation

@coryan
Copy link
Collaborator

@coryan coryan commented Apr 2, 2025

CredentialError represents problems trying to create the
authentication credentials. Some of these errors are recoverable, e.g.,
trying to fetch access tokens from the metadata server. Other errors are
not, e.g., malformed credential files.

Part of the work for #1542

@codecov
Copy link

codecov bot commented Apr 2, 2025

Codecov Report

Attention: Patch coverage is 95.45455% with 1 line in your changes missing coverage. Please review.

Project coverage is 95.94%. Comparing base (e94de76) to head (76a8547).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
src/gax/src/error/credentials.rs 95.45% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #1688      +/-   ##
==========================================
- Coverage   95.94%   95.94%   -0.01%     
==========================================
  Files          47       48       +1     
  Lines        1850     1872      +22     
==========================================
+ Hits         1775     1796      +21     
- Misses         75       76       +1     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review April 2, 2025 16:36
@coryan coryan requested review from codyoss and dbolduc April 2, 2025 16:36
coryan added 5 commits April 2, 2025 15:49
`CredentialError` represents problems trying to create the
authentication credentials. Some of these errors are recoverable, e.g.,
trying to fetch access tokens from the metadata server. Other errors are
not, e.g., malformed credential files.
@coryan coryan force-pushed the feat-gax-new-error-for-credentials branch from d4d6064 to 76a8547 Compare April 2, 2025 19:50
@coryan coryan enabled auto-merge (squash) April 2, 2025 19:50
@coryan coryan merged commit 07208a6 into googleapis:main Apr 2, 2025
20 checks passed
@coryan coryan deleted the feat-gax-new-error-for-credentials branch April 2, 2025 20:16
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants