feat(auth): support non-default User account credentials#1747
Merged
harkamaljot merged 12 commits intogoogleapis:mainfrom Apr 9, 2025
Merged
feat(auth): support non-default User account credentials#1747harkamaljot merged 12 commits intogoogleapis:mainfrom
harkamaljot merged 12 commits intogoogleapis:mainfrom
Conversation
…ud-rust into user-cred-builder
sai-sunder-s
requested changes
Apr 8, 2025
7a0aa4c to
63a40c0
Compare
…ud-rust into user-cred-builder
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1747 +/- ##
==========================================
+ Coverage 95.79% 95.83% +0.04%
==========================================
Files 50 50
Lines 1904 1923 +19
==========================================
+ Hits 1824 1843 +19
Misses 80 80 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
d039ffb to
20eaea6
Compare
…ud-rust into user-cred-builder
sai-sunder-s
approved these changes
Apr 9, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Implementation Details
Builderstruct withinuser_account.rsto acceptauthorized_userjson from the user.scopes,token_uri, andquota_project_idparameters.Refactoring
user.rstouser_account.rsas reading documentation the latter name seemed more coherent and maintain consistency withservice_account.rs.Testing
scopes,token_uri, andquota_project_idcorrectly override any defaults.