impl(o11y): add resource_name support for gRPC tracing#4035
Merged
westarle merged 3 commits intogoogleapis:mainfrom Dec 9, 2025
Merged
impl(o11y): add resource_name support for gRPC tracing#4035westarle merged 3 commits intogoogleapis:mainfrom
westarle merged 3 commits intogoogleapis:mainfrom
Conversation
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4035 +/- ##
==========================================
- Coverage 95.23% 95.22% -0.01%
==========================================
Files 171 171
Lines 6467 6476 +9
==========================================
+ Hits 6159 6167 +8
- Misses 308 309 +1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
westarle
force-pushed
the
impl/grpc-resource-name
branch
from
8fa5c5d to
1661efb
Compare
westarle
force-pushed
the
impl/grpc-resource-name
branch
from
1661efb to
fdd90ad
Compare
coryan
previously approved these changes
Dec 9, 2025
Collaborator
coryan
left a comment
coryan
left a comment
There was a problem hiding this comment.
Small improvements (maybe, I am not sure, look at them and tell me what you think). None of them blocking.
…s_str` methods and update test credential usage.
coryan
previously approved these changes
Dec 9, 2025
coryan
approved these changes
Dec 9, 2025
This was referenced Mar 10, 2026
Closed
haphungw
added a commit
to googleapis/librarian
that referenced
this pull request
Mar 12, 2026
Integrate `google.api.resource_reference` explicit extraction into tracing telemetry. When explicit resource annotations are available (`HasResourceNameFields`), the templates now extract the value directly from the generated request object and pass it via `options::internal::set_resource_name`, without having to fall back on the heuristic. Depends on: googleapis/google-cloud-rust#3771 googleapis/google-cloud-rust#4035 Fixes #4440
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.