WIP - feat: configurable crypto provider #4182
Closed
+516
−229
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
houseme
reviewed
Jan 8, 2026
| "dep:tokio", | ||
| "dep:tracing", | ||
| ] | ||
| _internal-grpc-client = [ |
There was a problem hiding this comment.
Are dep:google-cloud-auth(40 line and 57 line) and dep:gax( 43 line and 60 line ) duplicate imports?
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4182 +/- ##
=======================================
Coverage 94.77% 94.77%
=======================================
Files 187 187
Lines 7119 7119
=======================================
Hits 6747 6747
Misses 372 372 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
force-pushed
the
chore-deps-update-reqwest-to-0.13
branch
5 times, most recently
from
435f5e7 to
e65c508
Compare
|
It is recommended to prioritize the three crates of 'google-cloud-storage','google-cloud-auth', and 'google-cloud-gax-internal' and release new versions. |
Fix formatting Add requirements for gax-internal
coryan
force-pushed
the
chore-deps-update-reqwest-to-0.13
branch
from
e65c508 to
9fa5fc2
Compare
Collaborator
Author
|
Closing for now, track the work in #4170 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is just for testing, I need to break down the PR into smaller changes, complete the changes for generated clients, and add some builds to run the new
crypto-providerstests.