Skip to content

fix: restore regeneration#4292

Merged
JoeWang1127 merged 14 commits intogoogleapis:mainfrom
JoeWang1127:fix/restore-gen-all
Jan 20, 2026
Merged

fix: restore regeneration#4292
JoeWang1127 merged 14 commits intogoogleapis:mainfrom
JoeWang1127:fix/restore-gen-all

Conversation

@JoeWang1127
Copy link
Copy Markdown
Contributor

@JoeWang1127 JoeWang1127 commented Jan 15, 2026 •
edited
Loading

Restore library regeneration after resolving googleapis/librarian#3561.

Also update librarian version and librarian.yaml.

Fixes #4288

@JoeWang1127 JoeWang1127 changed the title fix: restore generating all libraries fix: restore regeneration Jan 15, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Jan 15, 2026 •
edited
Loading

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.84%. Comparing base (7af32ff) to head (cb12818).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files 
@@           Coverage Diff           @@
##             main    #4292   +/-   ##
=======================================
  Coverage   94.84%   94.84%           
=======================================
  Files         187      187           
  Lines        7195     7195           
=======================================
  Hits         6824     6824           
  Misses        371      371

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@JoeWang1127
Copy link
Copy Markdown
Contributor Author

JoeWang1127 commented Jan 15, 2026

Filed issue for failure in generating google-cloud-compute-v1: googleapis/librarian#3575

@coryan
Copy link
Copy Markdown
Contributor

coryan commented Jan 15, 2026

Filed issue for failure in generating google-cloud-compute-v1: googleapis/librarian#3575

I suspect google-cloud-compute-v1 now needs a source-root override.

@JoeWang1127 JoeWang1127 marked this pull request as ready for review January 19, 2026 18:43
@JoeWang1127 JoeWang1127 requested a review from a team January 19, 2026 18:43
@JoeWang1127 JoeWang1127 enabled auto-merge (squash) January 19, 2026 18:46
coryan
coryan approved these changes Jan 20, 2026
View reviewed changes
Comment thread librarian.yaml
output: src/generated/cloud/gkehub/configmanagement/v1
rust:
title_override: GKE Hub Types
rust: {}
Copy link
Copy Markdown
Contributor

@coryan coryan Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think @dbolduc asked this elsewhere. Looks like we can remove these lines, they represent "no rust overrides", right?

Maybe something to try in a follow up PR.

Copy link
Copy Markdown
Contributor

@coryan coryan Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See #4307

Copy link
Copy Markdown
Contributor Author

@JoeWang1127 JoeWang1127 Jan 20, 2026

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The title moved from the configuration to https://github.com/googleapis/librarian/blob/acaf08d7b78898d47c9c4e488cac49b5c083f5bc/internal/serviceconfig/api.go#L227

@JoeWang1127 JoeWang1127 merged commit 23e1a78 into googleapis:main Jan 20, 2026
30 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@coryan coryan coryan approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

The regenerate build is flaky

2 participants

@JoeWang1127 @coryan