Skip to content

Conversation

@PhongChuong
Copy link
Collaborator

Force reqwest to use http1 only as we currently do not support HTTP2 in our clients.

@codecov
Copy link

codecov bot commented Jan 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 94.84%. Comparing base (f6a578e) to head (bbc57df).
⚠️ Report is 4 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4296   +/-   ##
=======================================
  Coverage   94.84%   94.84%           
=======================================
  Files         187      187           
  Lines        7194     7195    +1     
=======================================
+ Hits         6823     6824    +1     
  Misses        371      371           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@PhongChuong PhongChuong marked this pull request as ready for review January 16, 2026 19:13
@PhongChuong PhongChuong requested a review from a team as a code owner January 16, 2026 19:13
@PhongChuong
Copy link
Collaborator Author

Note: I was able to manually test this with @dbolduc repro instructions. However, I couldn't find a good place to automate the testing since it requires adding the "http2" feature to reqwest in the cargo.toml. Any pointer in that regard is welcomed.

@coryan
Copy link
Collaborator

coryan commented Jan 16, 2026

Note: I was able to manually test this with @dbolduc repro instructions. However, I couldn't find a good place to automate the testing since it requires adding the "http2" feature to reqwest in the cargo.toml. Any pointer in that regard is welcomed.

I think you would need a new integration test crate that enables that feature, and you would need to run that with cargo test --package new-crate-name. Make sure the new crate is not in the default-members list. If you try to add this to an existing crate all the tests in that crate would gain the feature. And if it is in the default-members list then any cargo test would include them and enable the feature for everybody else too.

@PhongChuong PhongChuong merged commit c07269d into googleapis:main Jan 16, 2026
30 checks passed
@PhongChuong PhongChuong deleted the http1 branch January 24, 2026 03:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants