feat(dns/v1): add LRO helpers #4376
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
coryan
force-pushed
the
feat-dns-v1-add-lro-helpers
branch
from
bc1dd82 to
a123c22
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #4376 +/- ##
==========================================
+ Coverage 94.92% 94.94% +0.01%
==========================================
Files 191 191
Lines 7234 7234
==========================================
+ Hits 6867 6868 +1
+ Misses 367 366 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Cloud DNS has a couple of LRO-type functions. Enabling the LRO wrappers requires a few lines of hand-crafted code. Note that the `librarian.yaml` file refers to the symbols without a package name. That is needed because discovery-based services do not have a package name. If you think: "But what about the Compute package further up in the file?": for Compute we "infer" a package name from the service config yaml file, but we have no such file for Cloud DNS. With these changes I think the client library is ready to publish.
coryan
force-pushed
the
feat-dns-v1-add-lro-helpers
branch
from
a123c22 to
8eff05a
Compare
dbolduc
approved these changes
Jan 24, 2026
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cloud DNS has a couple of LRO-type functions. Enabling the LRO wrappers
requires a few lines of hand-crafted code.
Note that the
librarian.yamlfile refers to the symbols without a packagename. That is needed because discovery-based services do not have a package
name. If you think: "But what about the Compute package further up in the
file?": for Compute we "infer" a package name from the service config yaml
file, but we have no such file for Cloud DNS.
With these changes I think the client library is ready to publish.