impl(gax-internal): recorder and logging#5148
Merged
coryan merged 4 commits intogoogleapis:mainfrom Mar 26, 2026
Merged
Conversation
Introduce `WithLogging` a decorator for `std::future::Future` that creates the L3 logs entries with the future completes.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #5148 +/- ##
==========================================
+ Coverage 97.89% 97.90% +0.01%
==========================================
Files 212 213 +1
Lines 42442 42655 +213
==========================================
+ Hits 41549 41763 +214
+ Misses 893 892 -1 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
dbolduc
approved these changes
Mar 26, 2026
westarle
reviewed
Mar 26, 2026
Contributor
westarle
left a comment
westarle
left a comment
There was a problem hiding this comment.
a bunch of nits...
I think we should fix ERROR -> WARN and allow for sanitizing url.full before we forget.
...and I'd really like to see the 'actionable error' info be included at this log level so people don't have to turn on noisy debug logs to get it. I can imagine this as another PR.
coryan
commented
Mar 26, 2026
| { GCP_CLIENT_REPO } = snapshot.client_repo(), | ||
| { GCP_CLIENT_ARTIFACT } = snapshot.client_artifact(), | ||
| { URL_DOMAIN } = snapshot.default_host(), | ||
| { URL_FULL } = snapshot.url(), |
Contributor
Author
There was a problem hiding this comment.
Yes, added an IOU TODO.
westarle
approved these changes
Mar 26, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Introduce
WithLogginga decorator forstd::future::Futurethat creates the L3 logs entries with the future completes.Part of the work for #4772