Skip to content

impl(gax-internal): fallback on URL for server address#5155

Merged
coryan merged 3 commits intogoogleapis:mainfrom
coryan:feat-gax-internal-use-url-as-fallback-for-addresss-port
Mar 26, 2026
Merged

impl(gax-internal): fallback on URL for server address#5155
coryan merged 3 commits intogoogleapis:mainfrom
coryan:feat-gax-internal-use-url-as-fallback-for-addresss-port

Conversation

@coryan
Copy link
Copy Markdown
Contributor

@coryan coryan commented Mar 26, 2026

Fixes #5144

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 26, 2026

Codecov Report

❌ Patch coverage is 96.92308% with 2 lines in your changes missing coverage. Please review.
✅ Project coverage is 97.90%. Comparing base (b8f8f74) to head (11c01ac).
⚠️ Report is 2 commits behind head on main.

Files with missing lines Patch % Lines
...ernal/src/observability/client_signals/recorder.rs 96.82% 2 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5155      +/-   ##
==========================================
- Coverage   97.90%   97.90%   -0.01%     
==========================================
  Files         213      213              
  Lines       42664    42720      +56     
==========================================
+ Hits        41772    41825      +53     
- Misses        892      895       +3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@coryan coryan marked this pull request as ready for review March 26, 2026 15:36
@coryan coryan requested a review from a team as a code owner March 26, 2026 15:36
Comment thread src/gax-internal/src/observability/client_signals/recorder.rs
@coryan coryan enabled auto-merge (squash) March 26, 2026 16:56
@coryan coryan merged commit e76e9b0 into googleapis:main Mar 26, 2026
36 checks passed
@coryan coryan deleted the feat-gax-internal-use-url-as-fallback-for-addresss-port branch March 26, 2026 17:17
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

ClientSnapshot::server_address should return actual endpoint attempted

2 participants