Skip to content

cleanup(pubsub): remove MessageStream::close()#5263

Merged
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:cleanup-pubsub-remove-message-stream-close
Apr 6, 2026
Merged

cleanup(pubsub): remove MessageStream::close()#5263
dbolduc merged 1 commit intogoogleapis:mainfrom
dbolduc:cleanup-pubsub-remove-message-stream-close

Conversation

@dbolduc
Copy link
Copy Markdown
Member

@dbolduc dbolduc commented Apr 4, 2026

Fixes #5024

We can use the public APIs in our unit tests now and remove the test-only helper.

@product-auto-label product-auto-label Bot added the api: pubsub Issues related to the Pub/Sub API. label Apr 4, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 4, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.98%. Comparing base (c166879) to head (aa6d436).
⚠️ Report is 8 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5263      +/-   ##
==========================================
- Coverage   97.98%   97.98%   -0.01%     
==========================================
  Files         215      215              
  Lines       44904    44899       -5     
==========================================
- Hits        43999    43994       -5     
  Misses        905      905              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc marked this pull request as ready for review April 4, 2026 19:37
@dbolduc dbolduc requested a review from a team as a code owner April 4, 2026 19:37
@dbolduc dbolduc merged commit ae0e654 into googleapis:main Apr 6, 2026
36 checks passed
@dbolduc dbolduc deleted the cleanup-pubsub-remove-message-stream-close branch April 6, 2026 17:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsub Issues related to the Pub/Sub API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Applications can signal and await subscriber shutdown

2 participants