cleanup(spanner): generate grpc-mock#5433
Merged
dbolduc merged 5 commits intogoogleapis:mainfrom Apr 16, 2026
Merged
Conversation
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #5433 +/- ##
==========================================
- Coverage 97.74% 97.74% -0.01%
==========================================
Files 216 216
Lines 47592 47549 -43
==========================================
- Hits 46519 46476 -43
Misses 1073 1073 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
coryan
approved these changes
Apr 16, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes #5396
Replaces
src/spanner/grpc-mockwith a sidekick-generated version.The return type for streams was changed from our other services. I went through and manually updated the existing tests.
The PR is split into multiple commits to maybe make reviewing easier.
@olavloite - You have many pending PRs. If any of them are using the
Box::pin(...)return type, we need to coordinate merging them before/after this PR.