Skip to content

cleanup(spanner): generate grpc-mock#5433

Merged
dbolduc merged 5 commits intogoogleapis:mainfrom
dbolduc:cleanup-spanner-generate-grpc-mock
Apr 16, 2026
Merged

cleanup(spanner): generate grpc-mock#5433
dbolduc merged 5 commits intogoogleapis:mainfrom
dbolduc:cleanup-spanner-generate-grpc-mock

Conversation

@dbolduc
Copy link
Copy Markdown
Member

@dbolduc dbolduc commented Apr 16, 2026

Fixes #5396

Replaces src/spanner/grpc-mock with a sidekick-generated version.

The return type for streams was changed from our other services. I went through and manually updated the existing tests.

The PR is split into multiple commits to maybe make reviewing easier.

@olavloite - You have many pending PRs. If any of them are using the Box::pin(...) return type, we need to coordinate merging them before/after this PR.

@dbolduc dbolduc requested a review from olavloite April 16, 2026 17:52
@product-auto-label product-auto-label Bot added the api: spanner Issues related to the Spanner API. label Apr 16, 2026
@codecov
Copy link
Copy Markdown

codecov Bot commented Apr 16, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 97.74%. Comparing base (5d354cb) to head (99fdf81).
⚠️ Report is 1 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #5433      +/-   ##
==========================================
- Coverage   97.74%   97.74%   -0.01%     
==========================================
  Files         216      216              
  Lines       47592    47549      -43     
==========================================
- Hits        46519    46476      -43     
  Misses       1073     1073              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@dbolduc dbolduc marked this pull request as ready for review April 16, 2026 21:18
@dbolduc dbolduc requested review from a team as code owners April 16, 2026 21:18
@dbolduc dbolduc merged commit a2ccb22 into googleapis:main Apr 16, 2026
35 checks passed
@dbolduc dbolduc deleted the cleanup-spanner-generate-grpc-mock branch April 16, 2026 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the Spanner API.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Use generated grpc-mock

2 participants