Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: get recordvalue by field name #718

Merged
merged 2 commits into from Sep 2, 2020
Merged

Conversation

pmakani
Copy link
Contributor

@pmakani pmakani commented Sep 2, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #207

@google-cla google-cla bot added the cla: yes label Sep 2, 2020
@pmakani pmakani added the kokoro:force-run label Sep 2, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 2, 2020
@pmakani pmakani added the kokoro:force-run label Sep 2, 2020
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run label Sep 2, 2020
@codecov
Copy link

@codecov codecov bot commented Sep 2, 2020

Codecov Report

Merging #718 into master will increase coverage by 0.00%.
The diff coverage is 83.33%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #718   +/-   ##
=========================================
  Coverage     81.06%   81.07%           
  Complexity     1236     1236           
=========================================
  Files            78       78           
  Lines          6332     6334    +2     
  Branches        703      705    +2     
=========================================
+ Hits           5133     5135    +2     
  Misses          833      833           
  Partials        366      366           
Impacted Files Coverage Δ Complexity Δ
...n/java/com/google/cloud/bigquery/BigQueryImpl.java 82.90% <83.33%> (+0.05%) 77.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update b75b95b...d54d780. Read the comment docs.

@pmakani pmakani merged commit b3f59b1 into googleapis:master Sep 2, 2020
17 checks passed
@pmakani pmakani deleted the bigquery-207 branch Sep 2, 2020
gcf-merge-on-green bot pushed a commit that referenced this issue Sep 15, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants