Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add default stream support for StreamWriter #744

Merged
merged 12 commits into from Dec 17, 2020

Conversation

yirutang
Copy link
Contributor

@yirutang yirutang commented Dec 16, 2020

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #<issue_number_goes_here> ☕️

@yirutang yirutang requested a review from as a code owner Dec 16, 2020
@yirutang yirutang requested a review from pmakani Dec 16, 2020
@product-auto-label product-auto-label bot added the api: bigquerystorage label Dec 16, 2020
@google-cla google-cla bot added the cla: yes label Dec 16, 2020
@codecov
Copy link

@codecov codecov bot commented Dec 16, 2020

Codecov Report

Merging #744 (393ce44) into master (c32a86a) will increase coverage by 0.03%.
The diff coverage is n/a.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #744      +/-   ##
============================================
+ Coverage     80.25%   80.29%   +0.03%     
  Complexity      957      957              
============================================
  Files            73       73              
  Lines          5319     5319              
  Branches        401      401              
============================================
+ Hits           4269     4271       +2     
+ Misses          880      879       -1     
+ Partials        170      169       -1     
Impacted Files Coverage Δ Complexity Δ
...e/cloud/bigquery/storage/v1beta2/StreamWriter.java 84.24% <ø> (+0.45%) 37.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update c32a86a...393ce44. Read the comment docs.

@stephaniewang526 stephaniewang526 merged commit 248ab73 into googleapis:master Dec 17, 2020
19 checks passed
@yirutang yirutang deleted the default-stream branch Feb 18, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigquerystorage cla: yes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants