Skip to content

fix: prevent npe in metrics during a batching retry #4516

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Dec 1, 2025
Merged

fix: prevent npe in metrics during a batching retry #4516

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
dafe6a6
fix: prevent npe in metrics during a batching retry
igorbernstein2 Dec 1, 2025
6a5afd8
comment
igorbernstein2 Dec 1, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 5 additions & 3 deletions ...java/com/google/cloud/bigtable/hbase/wrappers/veneer/metrics/MetricsApiTracerAdapter.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -156,9 +156,11 @@ public void attemptFailed(Throwable error, Duration delay) {
lastRetryStatus = RetryStatus.ATTEMPT_RETRYABLE_FAILURE;
rpcMetrics.markRetry();
activeRpcCounter.dec();
BigtableClientMetrics.meter(
MetricLevel.Info, "grpc.errors." + Status.fromThrowable(error).getCode())
.mark();

// For batching, retries can be invoked despite the rpc status being OK because an entry failed.
Status status = (error == null) ? Status.OK : Status.fromThrowable(error);

BigtableClientMetrics.meter(MetricLevel.Info, "grpc.errors." + status.getCode()).mark();
}

@Override
Expand Down