fix: logic to suppress failed metric export during client shutdown#2858
Merged
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:mainfrom Apr 1, 2026
Merged
Conversation
Otel will try to do a final export when its shutting down, however that request can be rejected by the monitoring api due to rate limits. So previously we added an option to suppress the scary log warning. Unfortunately it had a logic bug that prevented it from working. This fixes it Change-Id: Id62af7fadc8beea41f5bfd011f7bc7c0899198ab
steveniemitz
approved these changes
Apr 1, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Otel will try to do a final export when its shutting down, however that request can be rejected by the monitoring api due to rate limits. So previously we added an option to suppress the scary log warning. Unfortunately it had a logic bug that prevented it from working. This fixes it
Change-Id: Id62af7fadc8beea41f5bfd011f7bc7c0899198ab
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️
If you write sample code, please follow the samples format.