Skip to content

fix: logic to suppress failed metric export during client shutdown#2858

Merged
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:mainfrom
igorbernstein2:fix-exporter-logging
Apr 1, 2026
Merged

fix: logic to suppress failed metric export during client shutdown#2858
gcf-merge-on-green[bot] merged 1 commit intogoogleapis:mainfrom
igorbernstein2:fix-exporter-logging

Conversation

@igorbernstein2
Copy link
Copy Markdown
Contributor

Otel will try to do a final export when its shutting down, however that request can be rejected by the monitoring api due to rate limits. So previously we added an option to suppress the scary log warning. Unfortunately it had a logic bug that prevented it from working. This fixes it

Change-Id: Id62af7fadc8beea41f5bfd011f7bc7c0899198ab

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)
  • Rollback plan is reviewed and LGTMed
  • All new data plane features have a completed end to end testing plan

Fixes #<issue_number_goes_here> ☕️

If you write sample code, please follow the samples format.

Otel will try to do a final export when its shutting down, however that request can be rejected by the monitoring api due to rate limits. So previously we added an option to suppress the scary log warning. Unfortunately it had a logic bug that prevented it from working. This fixes it

Change-Id: Id62af7fadc8beea41f5bfd011f7bc7c0899198ab
@igorbernstein2 igorbernstein2 requested review from a team as code owners April 1, 2026 13:36
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: bigtable Issues related to the googleapis/java-bigtable API. labels Apr 1, 2026
@igorbernstein2 igorbernstein2 added the automerge Merge the pull request once unit tests and other checks pass. label Apr 1, 2026
@gcf-merge-on-green gcf-merge-on-green bot merged commit ae0f0ef into googleapis:main Apr 1, 2026
25 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 1, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: bigtable Issues related to the googleapis/java-bigtable API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants