Skip to content

chore: regenerate common config#186

Closed
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth-self
Closed

chore: regenerate common config#186
yoshi-automation wants to merge 1 commit intomasterfrom
autosynth-self

Conversation

@yoshi-automation
Copy link
Copy Markdown
Contributor

This PR was generated using Autosynth. 🌈

Synth log will be available here:
https://source.cloud.google.com/results/invocations/a89ada08-4dfb-47d5-b8f7-042aafb7f10f/targets

  • To automatically regenerate this PR, check this box.

        autosynth cannot find the source of changes triggered by earlier changes in this
        repository, or by version upgrades to tools such as linters.
@yoshi-automation yoshi-automation requested a review from a team September 17, 2020 21:52
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 17, 2020
@codecov
Copy link
Copy Markdown

codecov bot commented Sep 17, 2020

Codecov Report

Merging #186 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff            @@
##             master    #186   +/-   ##
========================================
  Coverage      0.41%   0.41%           
  Complexity       19      19           
========================================
  Files            12      12           
  Lines         13375   13375           
  Branches       2620    2620           
========================================
  Hits             55      55           
  Misses        13317   13317           
  Partials          3       3           

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 5b7694d...6214834. Read the comment docs.

@BenWhitehead BenWhitehead changed the title [CHANGE ME] Re-generated to pick up changes from self. chore: regenerate common config Sep 18, 2020
@BenWhitehead
Copy link
Copy Markdown
Collaborator

@JustinBeckwith synth doesn't seem to know that this repo should have yoshi-java as a code-owner and is trying to undo the part of the change from #181. Do you know why this might be happening?

@stephaniewang526
Copy link
Copy Markdown
Contributor

@JustinBeckwith synth doesn't seem to know that this repo should have yoshi-java as a code-owner and is trying to undo the part of the change from #181. Do you know why this might be happening?

Hi @BenWhitehead -- i think you need to set codeowner_team property in .repo-metadata.json in order for the correct CODEOWNERS team to be generated by synthtool. Example of setting the metadata in bigquerystorage repo and the generated template change.

.github/sync-repo-settings.yaml is used to grant teams correct permissions to the repo so that CODEOWNERS can be actually effective (for instance, if we added @googleapis/yoshi-java as CODEOWNER in this repo but did not grant it Write permission, it won't be assigned when a PR is proposed).

With this said, I think all you need to do here is to add codeowner_team property in .repo-metadata.json in this repo.

Hope this helps! cc @chingor13

@BenWhitehead
Copy link
Copy Markdown
Collaborator

Fixed config file in #192 which incorrectly resulted in the proposed change

@BenWhitehead BenWhitehead deleted the autosynth-self branch September 22, 2020 17:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement. context: none

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants