chore: Change the Codeowner to cloud-native-db-dpes #686
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
the
api: datastore
kolea2
suggested changes
Mar 18, 2022
.github/CODEOWNERS
Outdated
| * @googleapis/yoshi-java @googleapis/firestore-dpe | ||
| **/*.java @googleapis/firestore-dpe | ||
| # The @googleapis/cloud-native-db-dpes is the default owner for changes in this repo | ||
| * @googleapis/yoshi-java @googleapis/cloud-native-db-dpes |
Contributor
There was a problem hiding this comment.
we should have both teams rather than replace them
Contributor
Author
There was a problem hiding this comment.
The googleapis/firestore-dpe team doesn't seem to exist 😅 that's why we're replacing it with the cloud-native-db-dpes team.
Contributor
There was a problem hiding this comment.
oops sorry looked too quickly! That should be replaced with api-firestore
Contributor
Author
There was a problem hiding this comment.
Ok, I've added api-firestore as codeowner.
|
Warning: This pull request is touching the following templated files:
|
kolea2
approved these changes
Mar 21, 2022
kolea2
pushed a commit
to kolea2/java-datastore
that referenced
this pull request
Apr 19, 2022
* chore: Change the Codeowner to cloud-native-db-dpes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add api-firestore team * Update CODEOWNERS * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add @googleapis/api-firestore to the codeowner * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
kolea2
added a commit
that referenced
this pull request
Apr 20, 2022
* chore: Change the Codeowner to cloud-native-db-dpes (#686) * chore: Change the Codeowner to cloud-native-db-dpes * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add api-firestore team * Update CODEOWNERS * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md * Add @googleapis/api-firestore to the codeowner * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com> * 🦉 Updates from OwlBot post-processor See https://github.com/googleapis/repo-automation-bots/blob/main/packages/owl-bot/README.md Co-authored-by: Mariatta Wijaya <Mariatta@users.noreply.github.com> Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Replaced
@googleapis/firestore-dpewith@googleapis/cloud-native-db-dpes