feat: Add the ability to use automatic subscriber assignment to the subscriber settings by dpcollins-google · Pull Request #163 · googleapis/java-pubsublite

dpcollins-google · 2020-07-15T15:10:11Z

No description provided.

…subscriber settings. Also disable clirr as it fires on this PR. We are not providing interface stability guarantees.

anguillanneuf · 2020-07-15T17:05:54Z

Please fix the tests first.

anguillanneuf

The changes in samples/ looks fine. Please also update .readme-partials.yaml and fix tests.

anguillanneuf · 2020-07-15T18:16:54Z

samples/snippets/pom.xml

      <groupId>com.google.cloud</groupId>
      <artifactId>google-cloud-pubsublite</artifactId>
-      <version>0.1.7</version>
+      <version>0.1.9-SNAPSHOT</version>


Please don't update this to SNAPSHOT as this will get mirrored in https://cloud.google.com/pubsub/lite/docs/reference/libraries
Generally, autosynth will take care of updating version numbers in POM files.

Autosynth doesn't seem to be updating this number? At least it didnt in release 1.8 which is confusing.

It may have something to do with most snippets folders usually don't require version updates / they use libraries bom. @chingor13 is that right? See history: https://github.com/googleapis/java-pubsublite/commits/master/samples/snippets/pom.xml How do we overwrite the update rule?

We never successfully released any version after 0.1.7: https://mvnrepository.com/artifact/com.google.cloud/google-cloud-pubsublite

google-cloud-pubsublite/pom.xml

dpcollins-google · 2020-07-15T20:15:01Z

Please fix the tests first.

The tests are broken due to "[08:14:28][ERROR] Timed out waiting for GitHub to return mergeable status for the pull (PR). GitHub is taking too long to compute whether this PR is mergeable. Please retry the build in a few minutes. You can do this by attaching a kokoro:force-run label on your PR." which sounds like a kokoro issue.

dpcollins-google · 2020-07-15T20:38:38Z

.readme-partials.yaml updated.

anguillanneuf · 2020-07-15T21:34:12Z

Samples update should come later, after the library has a new release that picks up the changes. If you want, you can split this into two. Or I can update the samples later.

codecov · 2020-07-15T22:09:42Z

Codecov Report

Merging #163 into master will decrease coverage by 1.09%.
The diff coverage is 0.00%.

@@             Coverage Diff              @@
##             master     #163      +/-   ##
============================================
- Coverage     61.16%   60.07%   -1.10%     
  Complexity      417      417              
============================================
  Files            92       93       +1     
  Lines          2145     2184      +39     
  Branches        181      182       +1     
============================================
  Hits           1312     1312              
- Misses          736      775      +39     
  Partials         97       97

Impacted Files	Coverage Δ	Complexity Δ
...oud/pubsublite/cloudpubsub/SubscriberSettings.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (ø)`
...loud/pubsublite/internal/wire/AssignerBuilder.java	`0.00% <0.00%> (ø)`	`0.00 <0.00> (?)`

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 3c471ab...214af54. Read the comment docs.

anguillanneuf

I would like @hannahrogers-google or someone else comment on if more tests need to be added before you merge.

...oud-pubsublite/src/main/java/com/google/cloud/pubsublite/cloudpubsub/SubscriberSettings.java

hannahrogers-google · 2020-07-15T23:31:05Z

I would like @hannahrogers-google or someone else comment on if more tests need to be added before you merge.

I am ok with this change - I don't believe we have explicit unit tests for any of the Builders in the lite client library.

anguillanneuf

Cool. I can update samples in a different PR a bit later. Thanks!

Changes applied.

lesv

This doesn't appear to have a sample - so I'm just approving w/o review.

anguillanneuf · 2020-07-23T16:51:30Z

@dpcollins-google Does this Do Not Merge label still apply?

dpcollins-google · 2020-07-23T20:33:19Z

@dpcollins-google Does this Do Not Merge label still apply?

Yes it does. We don't want to merge this until the backend is tested internally and we've updated (/ are updating) the docs.

dpcollins-google added 2 commits June 11, 2020 15:41

[feat] Add the ability to use automatic subscriber assignment to the …

c2e8142

…subscriber settings. Also disable clirr as it fires on this PR. We are not providing interface stability guarantees.

No-op commit to update github.

0c43e23

dpcollins-google added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Jul 15, 2020

dpcollins-google requested review from a team, anguillanneuf and manuelmenzella-google July 15, 2020 15:10

googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jul 15, 2020

dpcollins-google force-pushed the sub-settings branch from 1c77ace to c2e8142 Compare July 15, 2020 15:52

anguillanneuf changed the title ~~[feat] Add the ability to use automatic subscriber assignment to the subscriber settings.~~ feat: Add the ability to use automatic subscriber assignment to the subscriber settings Jul 15, 2020

anguillanneuf previously requested changes Jul 15, 2020

View reviewed changes

anguillanneuf added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2020

yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jul 15, 2020

dpcollins-google force-pushed the sub-settings branch 2 times, most recently from afededa to f8039c7 Compare July 15, 2020 20:38

dpcollins-google force-pushed the sub-settings branch from f8039c7 to 0c43e23 Compare July 15, 2020 21:26

dpcollins-google added 2 commits July 15, 2020 17:56

Undo sample changes.

efed3dd

Revert lastt samples change.

214af54

anguillanneuf reviewed Jul 15, 2020

View reviewed changes

anguillanneuf self-requested a review July 15, 2020 22:53

hannahrogers-google reviewed Jul 15, 2020

View reviewed changes

...oud-pubsublite/src/main/java/com/google/cloud/pubsublite/cloudpubsub/SubscriberSettings.java Show resolved Hide resolved

anguillanneuf reviewed Jul 16, 2020

View reviewed changes

anguillanneuf self-requested a review July 16, 2020 20:37

anguillanneuf approved these changes Jul 17, 2020

View reviewed changes

lesv approved these changes Jul 17, 2020

View reviewed changes

dpcollins-google force-pushed the sub-settings branch from 3668663 to 214af54 Compare July 31, 2020 19:15

anguillanneuf mentioned this pull request Aug 5, 2020

samples: update samples for automatic subscriber assignment #189

Merged

dpcollins-google removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Aug 11, 2020

dpcollins-google merged commit a396f24 into master Aug 11, 2020

dpcollins-google deleted the sub-settings branch August 11, 2020 14:06

Conversation

dpcollins-google commented Jul 15, 2020

Uh oh!

anguillanneuf commented Jul 15, 2020

Uh oh!

anguillanneuf left a comment

Choose a reason for hiding this comment

Uh oh!

anguillanneuf Jul 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

dpcollins-google Jul 15, 2020

Choose a reason for hiding this comment

Uh oh!

anguillanneuf Jul 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Choose a reason for hiding this comment

Uh oh!

Uh oh!

dpcollins-google commented Jul 15, 2020

Uh oh!

dpcollins-google commented Jul 15, 2020

Uh oh!

anguillanneuf commented Jul 15, 2020

Uh oh!

codecov bot commented Jul 15, 2020 • edited Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Codecov Report

Uh oh!

anguillanneuf left a comment

Choose a reason for hiding this comment

Uh oh!

Uh oh!

hannahrogers-google commented Jul 15, 2020

Uh oh!

anguillanneuf left a comment

Choose a reason for hiding this comment

Uh oh!

lesv left a comment

Choose a reason for hiding this comment

Uh oh!

anguillanneuf commented Jul 23, 2020

Uh oh!

dpcollins-google commented Jul 23, 2020

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

6 participants

anguillanneuf Jul 15, 2020 •

edited

Loading

anguillanneuf Jul 15, 2020 •

edited

Loading

codecov bot commented Jul 15, 2020 •

edited

Loading