Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Make BufferingPullSubscriber use List instead of ImmutableList #256

Merged
merged 1 commit into from
Sep 28, 2020

Conversation

dpcollins-google
Copy link
Collaborator

This makes it friendly to use in beam.

@dpcollins-google dpcollins-google requested a review from a team as a code owner September 28, 2020 16:17
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Sep 28, 2020
@codecov
Copy link

codecov bot commented Sep 28, 2020

Codecov Report

Merging #256 into master will not change coverage.
The diff coverage is 100.00%.

Impacted file tree graph

@@            Coverage Diff            @@
##             master     #256   +/-   ##
=========================================
  Coverage     72.43%   72.43%           
- Complexity      771      772    +1     
=========================================
  Files           140      140           
  Lines          4096     4096           
  Branches        215      214    -1     
=========================================
  Hits           2967     2967           
  Misses         1004     1004           
  Partials        125      125           
Impacted Files Coverage Δ Complexity Δ
...d/pubsublite/internal/BufferingPullSubscriber.java 82.05% <100.00%> (ø) 4.00 <0.00> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update fcf5282...5ca9afd. Read the comment docs.

@dpcollins-google dpcollins-google merged commit a23e26f into master Sep 28, 2020
@dpcollins-google dpcollins-google deleted the bps-list branch September 28, 2020 16:48
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
cla: yes This human has signed the Contributor License Agreement.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants