Skip to content

nit: fix broken link in samples/README.md #40

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
anguillanneuf merged 3 commits into from
May 15, 2020
Merged

nit: fix broken link in samples/README.md #40

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
531d2f9
fix broken link in readme
anguillanneuf May 15, 2020
e9c195a
Merge branch 'master' into anguillanneuf-patch-1
anguillanneuf May 15, 2020
5de3a93
Merge branch 'master' into anguillanneuf-patch-1
anguillanneuf May 15, 2020
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
6 changes: 3 additions & 3 deletions samples/README.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,7 @@

However, tests require an additional environment variable `GOOGLE_CLOUD_PROJECT_NUMBER` to run. For instance,

In [`UpdateTopicExampleIT.java`](snippets/src/test/java/pubsublite/UpdateTopicExampleIT.java):
In [`QuickStartIT.java`](snippets/src/test/java/pubsublite/QuickStartIT.java):

```java
private static final String GOOGLE_CLOUD_PROJECT_NUMBER =
Expand All @@ -16,12 +16,12 @@ Here, the program needs you to provide your [Google Cloud Project Number](https:

To run a sample's integration test in Cloud Shell:

1. `cd samples/snippets` - all samples are located in `java-pubsublite/samples/snippets` directory.
1. `cd samples/` - all samples are located in `java-pubsublite/samples/snippets` directory.

1. `mvn clean -Dtest=QuickStartIT test` - this runs the integration test for `UpdateTopicExample.java`.

To run a sample, update the developer's TODO section in the snippet, then:

1. `cd samples/snippets` - all samples are located in `java-pubsublite/samples/snippets` directory.
1. `cd samples/snippets/` - all samples are located in `java-pubsublite/samples/snippets` directory.

1. `mvn compile exec:java -Dexec.mainClass=pubsublite.ListTopicsExample` - this should list the topics in your project.