feat: Use the partition watching publisher in the cps client#409
Merged
palmere-google merged 2 commits intomasterfrom Dec 10, 2020
Merged
feat: Use the partition watching publisher in the cps client#409palmere-google merged 2 commits intomasterfrom
palmere-google merged 2 commits intomasterfrom
Conversation
e04736a to
4a68c5a
Compare
4a68c5a to
c33eaae
Compare
Codecov Report
@@ Coverage Diff @@
## master #409 +/- ##
============================================
- Coverage 71.70% 71.68% -0.03%
- Complexity 814 840 +26
============================================
Files 156 158 +2
Lines 4404 4400 -4
Branches 219 223 +4
============================================
- Hits 3158 3154 -4
+ Misses 1126 1125 -1
- Partials 120 121 +1
Continue to review full report at Codecov.
|
dpcollins-google
approved these changes
Dec 10, 2020
...loud-pubsublite/src/main/java/com/google/cloud/pubsublite/cloudpubsub/PublisherSettings.java
Outdated
Show resolved
Hide resolved
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:
Fixes #<issue_number_goes_here> ☕️