Skip to content

Conversation

@dpcollins-google
Copy link
Collaborator

@dpcollins-google dpcollins-google commented Mar 17, 2021

  • UUIDs generated randomly are not valid UTF-8 strings so they cannot be read from the CPS shim by default
  • Restrictions on bundle closing make it hard to test PSL with windowing pipelines

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

Fixes #542 ☕️

- UUIDs generated randomly are not valid UTF-8 strings so they cannot be read from the CPS shim by default
- Restrictions on bundle closing make it hard to test PSL with windowing pipelines
@dpcollins-google dpcollins-google requested a review from a team as a code owner March 17, 2021 18:27
@product-auto-label product-auto-label bot added the api: pubsublite Issues related to the googleapis/java-pubsublite API. label Mar 17, 2021
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Mar 17, 2021
@codecov
Copy link

codecov bot commented Mar 17, 2021

Codecov Report

Merging #552 (bff816b) into master (39e04e4) will decrease coverage by 0.09%.
The diff coverage is 40.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##             master     #552      +/-   ##
============================================
- Coverage     72.70%   72.60%   -0.10%     
  Complexity      860      860              
============================================
  Files           156      156              
  Lines          4477     4483       +6     
  Branches        210      209       -1     
============================================
  Hits           3255     3255              
- Misses         1102     1107       +5     
- Partials        120      121       +1     
Impacted Files Coverage Δ Complexity Δ
...ogle/cloud/pubsublite/beam/SubscribeTransform.java 0.00% <0.00%> (ø) 0.00 <0.00> (ø)
...oogle/cloud/pubsublite/beam/SubscriberOptions.java 11.11% <20.00%> (+0.94%) 1.00 <0.00> (ø)
...in/java/com/google/cloud/pubsublite/beam/Uuid.java 84.61% <100.00%> (+2.79%) 3.00 <0.00> (ø)
...ubsublite/internal/BlockingPullSubscriberImpl.java 87.93% <0.00%> (-5.18%) 11.00% <0.00%> (-1.00%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 39e04e4...bff816b. Read the comment docs.

- UUIDs generated randomly are not valid UTF-8 strings so they cannot be read from the CPS shim by default
- Restrictions on bundle closing make it hard to test PSL with windowing pipelines
@dpcollins-google dpcollins-google merged commit d4682b6 into master Mar 17, 2021
@dpcollins-google dpcollins-google deleted the fix-beam-qol branch March 17, 2021 20:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: pubsublite Issues related to the googleapis/java-pubsublite API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

PubSubLite Not Advancing Watermarks in Dataflow/Beam Job

2 participants