Skip to content

feat: Remove BetaApi from reservation methods #906

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
dpcollins-google merged 1 commit into from
Oct 5, 2021
Merged

feat: Remove BetaApi from reservation methods #906

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 0 additions & 7 deletions google-cloud-pubsublite/src/main/java/com/google/cloud/pubsublite/AdminClient.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,7 +17,6 @@
package com.google.cloud.pubsublite;

import com.google.api.core.ApiFuture;
import com.google.api.core.BetaApi;
import com.google.api.gax.longrunning.OperationFuture;
import com.google.api.gax.rpc.ApiException;
import com.google.cloud.pubsublite.internal.ApiBackgroundResource;
Expand Down Expand Up @@ -194,7 +193,6 @@ OperationFuture<SeekSubscriptionResponse, OperationMetadata> seekSubscription(
* @return A future that will have either an error {@link com.google.api.gax.rpc.ApiException} or
* the reservation on success.
*/
@BetaApi("This may not be implemented in the backend, it is a pre-release feature.")
ApiFuture<Reservation> createReservation(Reservation reservation);

/**
Expand All @@ -204,7 +202,6 @@ OperationFuture<SeekSubscriptionResponse, OperationMetadata> seekSubscription(
* @return A future that will have either an error {@link com.google.api.gax.rpc.ApiException} or
* the reservation on success.
*/
@BetaApi("This may not be implemented in the backend, it is a pre-release feature.")
ApiFuture<Reservation> getReservation(ReservationPath path);

/**
Expand All @@ -214,7 +211,6 @@ OperationFuture<SeekSubscriptionResponse, OperationMetadata> seekSubscription(
* @return A future that will have either an error {@link com.google.api.gax.rpc.ApiException} or
* the list of reservation paths on success.
*/
@BetaApi("This may not be implemented in the backend, it is a pre-release feature.")
ApiFuture<List<Reservation>> listReservations(LocationPath path);

/**
Expand All @@ -227,7 +223,6 @@ OperationFuture<SeekSubscriptionResponse, OperationMetadata> seekSubscription(
* future to have an exception with status {@link
* com.google.api.gax.rpc.StatusCode.Code#NOT_FOUND}
*/
@BetaApi("This may not be implemented in the backend, it is a pre-release feature.")
ApiFuture<Reservation> updateReservation(Reservation reservation, FieldMask mask);

/**
Expand All @@ -238,7 +233,6 @@ OperationFuture<SeekSubscriptionResponse, OperationMetadata> seekSubscription(
* void on success. Deleting nonexistent reservations will cause the future to have an
* exception with status {@link com.google.api.gax.rpc.StatusCode.Code#NOT_FOUND}
*/
@BetaApi("This may not be implemented in the backend, it is a pre-release feature.")
ApiFuture<Void> deleteReservation(ReservationPath path);

/**
Expand All @@ -248,6 +242,5 @@ OperationFuture<SeekSubscriptionResponse, OperationMetadata> seekSubscription(
* @return A future that will have either an error {@link com.google.api.gax.rpc.ApiException} or
* the list of topics on success.
*/
@BetaApi("This may not be implemented in the backend, it is a pre-release feature.")
ApiFuture<List<TopicPath>> listReservationTopics(ReservationPath path);
}