fix: keep track of any BeginTransaction option for a Read #1486
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
If a StreamingReadRequest that included a BeginTransaction option was retried as a result of a transient error (UNAVAILABLE), the fact that the BeginTransaction option was included would not be registered for the retried request. This could cause a transaction to fail if the retried request returned an Aborted error, and that Aborted error was caught by the application.
product-auto-label
bot
added
the
api: spanner
google-cla
bot
added
the
cla: yes
suztomo
reviewed
Oct 5, 2021
| rpc.read(builder.build(), stream.consumer(), session.getOptions()); | ||
| call.request(prefetchChunks); | ||
| stream.setCall(call, selector != null && selector.hasBegin()); | ||
| stream.setCall(call, /* withBeginTransaction = */ builder.getTransaction().hasBegin()); |
Member
There was a problem hiding this comment.
Is this typo? Strange way to write an inline comment.
Collaborator
Author
There was a problem hiding this comment.
No, it's not a typo. It's the closest we get to named parameters in Java. We sometimes use it for (boolean) arguments that otherwise are not obvious what they are for.
Member
|
I see integration test failing. |
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
Collaborator
Author
Seems to be unrelated. I've created a tracking issue and restarted them. |
Member
|
I see it failed again. |
Collaborator
Author
I've increased the timeout in the specific test, and it now succeeds. The test is however completely unrelated to this change, so the test failure rather seems to be related to the backend needing more time than previously to delete a database. |
suztomo
approved these changes
Oct 5, 2021
thiagotnunes
approved these changes
Oct 6, 2021
Closed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a StreamingReadRequest that included a BeginTransaction option was retried as a result
of a transient error (UNAVAILABLE), the fact that the BeginTransaction option was included
would not be registered for the retried request. This could cause a transaction to fail if
the retried request returned an Aborted error, and that Aborted error was caught by the
application.