test: Deleting stale encrypted instances #1986
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… but not deleted due to system interrupts or timeout.
product-auto-label
bot
added
size: m
gauravpurohit06
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
gauravpurohit06
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
rajatbhatta
reviewed
Aug 30, 2022
samples/snippets/src/test/java/com/example/spanner/SpannerSampleIT.java
Outdated
Show resolved
Hide resolved
rajatbhatta
suggested changes
Aug 30, 2022
samples/snippets/src/test/java/com/example/spanner/SpannerSampleIT.java
Outdated
Show resolved
Hide resolved
rajatbhatta
reviewed
Aug 30, 2022
samples/snippets/src/test/java/com/example/spanner/SpannerSampleIT.java
Outdated
Show resolved
Hide resolved
rajatbhatta
reviewed
Aug 30, 2022
samples/snippets/src/test/java/com/example/spanner/SpannerSampleIT.java
Outdated
Show resolved
Hide resolved
product-auto-label
bot
added
size: s
gauravpurohit06
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
product-auto-label
bot
added
size: m
rajatbhatta
reviewed
Sep 1, 2022
samples/snippets/src/test/java/com/example/spanner/SpannerSampleIT.java
Outdated
Show resolved
Hide resolved
Co-authored-by: Rajat Bhatta <93644539+rajatbhatta@users.noreply.github.com>
rajatbhatta
reviewed
Sep 1, 2022
samples/snippets/src/test/java/com/example/spanner/SpannerSampleIT.java
Outdated
Show resolved
Hide resolved
rajatbhatta
approved these changes
Sep 1, 2022
Contributor
rajatbhatta
left a comment
rajatbhatta
left a comment
There was a problem hiding this comment.
LGTM, except just one comment https://github.com/googleapis/java-spanner/pull/1986/files#r960443381. Thanks for working on this.
gauravpurohit06
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1966