chore: use a cache for the statement parser #2790
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a cache for the statement parser that is used in the Connection API. This will reduce the number of times that a SQL string needs to be parsed by the JDBC driver and PGAdapter.
product-auto-label
bot
added
size: m
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
ankiaga
reviewed
Jan 22, 2024
...cloud-spanner/src/main/java/com/google/cloud/spanner/connection/AbstractStatementParser.java
Outdated
Show resolved
Hide resolved
ankiaga
reviewed
Jan 22, 2024
...cloud-spanner/src/main/java/com/google/cloud/spanner/connection/AbstractStatementParser.java
Outdated
Show resolved
Hide resolved
ankiaga
reviewed
Jan 22, 2024
...cloud-spanner/src/main/java/com/google/cloud/spanner/connection/AbstractStatementParser.java
Outdated
Show resolved
Hide resolved
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
ankiaga
reviewed
Jan 29, 2024
| // We do length*2 because Java uses 2 bytes for each char. | ||
| .weigher( | ||
| (Weigher<String, ParsedStatement>) | ||
| (key, value) -> 2 * key.length() + 2 * value.sqlWithoutComments.length()) |
Contributor
There was a problem hiding this comment.
Why are we only considering value.sqlWithoutComments as there are other attributes also stored as value? Is it because those have constant small size?
Collaborator
Author
There was a problem hiding this comment.
Yes, exactly. The other properties are all small, and all have fixed size. The statement (so the original SQL statement) is also not stored as part of the value in the cache, as that is the key that we are using.
ankiaga
approved these changes
Jan 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a cache for the statement parser that is used in the Connection API. This will reduce the number of times that a SQL string needs to be parsed by the JDBC driver and PGAdapter.