Skip to content

Conversation

@arpan14
Copy link
Contributor

@arpan14 arpan14 commented Apr 29, 2024

  • The existing setup using JMH produces flaky results at time due to thread safe scope variables and also it lacks the ability to pass different parameters from command-line.
  • This is a more light-weight setup which allows to pass params from command-line and keeps the setup much simpler.
  • This util also allows us to export metrics/traces directly to cloud monitoring so that its easy to visualize and compare stats.

@arpan14 arpan14 requested review from a team as code owners April 29, 2024 05:52
@product-auto-label product-auto-label bot added the size: l Pull request size is large. label Apr 29, 2024
@arpan14 arpan14 requested a review from harshachinta April 29, 2024 05:52
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Apr 29, 2024
@arpan14 arpan14 force-pushed the benchmark-util-pr branch 2 times, most recently from bf39376 to 62bc061 Compare April 29, 2024 06:26
@arpan14 arpan14 force-pushed the benchmark-util-pr branch from 62bc061 to 5c8d72d Compare April 29, 2024 06:39
@arpan14 arpan14 added automerge Merge the pull request once unit tests and other checks pass. owlbot:run Add this label to trigger the Owlbot post processor. labels Apr 29, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Apr 29, 2024
@gcf-merge-on-green gcf-merge-on-green bot merged commit eb62572 into googleapis:main Apr 29, 2024
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Apr 29, 2024
@arpan14 arpan14 deleted the benchmark-util-pr branch April 29, 2024 07:46
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants