Skip to content

feat: Add grpc.xds.resource_type label to xDS client metrics #4222

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 4 commits into from
Nov 17, 2025
Merged

feat: Add grpc.xds.resource_type label to xDS client metrics #4222

merged 4 commits into from
Nov 17, 2025
+3 −0

Conversation

@HailongWen
Copy link
Contributor

@HailongWen HailongWen commented Nov 14, 2025

This is a quick fix to add the missing grpc.xds.resource_type label in xds_client metrics (b/451687047).

@HailongWen HailongWen requested review from a team as code owners November 14, 2025 09:57
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/java-spanner API. labels Nov 14, 2025
surbhigarg92
surbhigarg92 previously approved these changes Nov 14, 2025
View reviewed changes
@rahul2393 rahul2393 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Nov 14, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2025
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 14, 2025
@rahul2393
Copy link
Contributor

rahul2393 commented Nov 14, 2025 •
edited
Loading

@HailongWen direct path tests are failing currently with below error

Caused by: com.google.api.gax.rpc.DeadlineExceededException: io.grpc.StatusRuntimeException: DEADLINE_EXCEEDED: CallOptions deadline exceeded after 29.986144493s. Name resolution delay 0.013323264 seconds. [closed=[], open=[[buffered_nanos=30015820924, waiting_for_connection]]]

Can you please help us to figure out what might be wrong, or add relevant folks here?

@HailongWen
Copy link
Contributor Author

HailongWen commented Nov 14, 2025

@HailongWen direct path tests are failing currently with below error

Caused by: com.google.api.gax.rpc.DeadlineExceededException: io.grpc.StatusRuntimeException: DEADLINE_EXCEEDED: CallOptions deadline exceeded after 29.986144493s. Name resolution delay 0.013323264 seconds. [closed=[], open=[[buffered_nanos=30015820924, waiting_for_connection]]]

Can you please help us to figure out what might be wrong, or add relevant folks here?

The error seems unrelated to this PR. And manual tests do not run into this issue. Will look into that internally.

@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 15, 2025
@rahul2393 rahul2393 added kokoro:force-run Add this label to force Kokoro to re-run the tests. automerge Merge the pull request once unit tests and other checks pass. labels Nov 17, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2025
@rahul2393 rahul2393 added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2025
@yoshi-kokoro yoshi-kokoro removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Nov 17, 2025
@rahul2393 rahul2393 merged commit 97bed3c into googleapis:main Nov 17, 2025
54 of 58 checks passed
@gcf-merge-on-green gcf-merge-on-green bot removed the automerge Merge the pull request once unit tests and other checks pass. label Nov 17, 2025
@release-please release-please bot mentioned this pull request Nov 17, 2025
Merged
gcf-merge-on-green bot pushed a commit that referenced this pull request Nov 17, 2025
@release-please
chore(main): release 6.103.0 (#4224)
4b5eadc 
🤖 I have created a release *beep* *boop*
---


## [6.103.0](https://togithub.com/googleapis/java-spanner/compare/v6.102.1...v6.103.0) (2025-11-17)


### Features

* Add grpc.xds.resource_type label to xDS client metrics ([#4222](https://togithub.com/googleapis/java-spanner/issues/4222)) ([97bed3c](https://togithub.com/googleapis/java-spanner/commit/97bed3cf1a9df542acc4685c2ce4dbfa629b2cd3))
* Exposing AutoscalingConfig in InstancePartition ([22edecf](https://togithub.com/googleapis/java-spanner/commit/22edecf8518844860c3cb47883544efd36cbc311))


### Bug Fixes

* Add env var to allow disabling directpath bound token ([#4189](https://togithub.com/googleapis/java-spanner/issues/4189)) ([0ca9541](https://togithub.com/googleapis/java-spanner/commit/0ca95412c778e3478cb66e4bea124396326c6056))
* Allow DML THEN RETURN with retryAbortsInternally=false ([#4225](https://togithub.com/googleapis/java-spanner/issues/4225)) ([f49cc47](https://togithub.com/googleapis/java-spanner/commit/f49cc47e663836696ef151738510e68324e139dc))
* **deps:** Update the Java code generator (gapic-generator-java) to 2.64.1 ([22edecf](https://togithub.com/googleapis/java-spanner/commit/22edecf8518844860c3cb47883544efd36cbc311))
* Remove URL encoding in project name ([#4188](https://togithub.com/googleapis/java-spanner/issues/4188)) ([abba0c1](https://togithub.com/googleapis/java-spanner/commit/abba0c1730ea792407bea073ea65da55128cd764))


### Dependencies

* Update actions/checkout action to v5 ([#4166](https://togithub.com/googleapis/java-spanner/issues/4166)) ([50a56f7](https://togithub.com/googleapis/java-spanner/commit/50a56f7d47541dd581f7b425df36a080ecc11a74))
* Update all tracing and telemetry dependencies ([#4230](https://togithub.com/googleapis/java-spanner/issues/4230)) ([d60124c](https://togithub.com/googleapis/java-spanner/commit/d60124cbe317d4c2489ea35de81943cfd2b8f697))
* Update dependency com.google.api.grpc:proto-google-cloud-trace-v1 to v2.79.0 ([#4172](https://togithub.com/googleapis/java-spanner/issues/4172)) ([3a329fd](https://togithub.com/googleapis/java-spanner/commit/3a329fdb2fc68ff9d19717b534dd667f931d51fd))
* Update dependency com.google.auto.value:auto-value-annotations to v1.11.1 ([#4216](https://togithub.com/googleapis/java-spanner/issues/4216)) ([84150c7](https://togithub.com/googleapis/java-spanner/commit/84150c73bbed2a6d58408ae0b8bd59709fc751db))
* Update dependency com.google.cloud:google-cloud-trace to v2.79.0 ([#4174](https://togithub.com/googleapis/java-spanner/issues/4174)) ([3e93ca0](https://togithub.com/googleapis/java-spanner/commit/3e93ca077b94ad06867e3c9fdfe19527855423a2))
* Update dependency com.google.cloud:sdk-platform-java-config to v3.54.1 ([#4193](https://togithub.com/googleapis/java-spanner/issues/4193)) ([ad235cf](https://togithub.com/googleapis/java-spanner/commit/ad235cfc9041f52c2f7b76f67eeaa6c03c5840aa))
* Update dependency commons-cli:commons-cli to v1.11.0 ([#4218](https://togithub.com/googleapis/java-spanner/issues/4218)) ([33449ba](https://togithub.com/googleapis/java-spanner/commit/33449baf64a3d5b78fff323737ffeb28c8a9461b))
* Update dependency commons-io:commons-io to v2.21.0 ([#4198](https://togithub.com/googleapis/java-spanner/issues/4198)) ([1f31169](https://togithub.com/googleapis/java-spanner/commit/1f3116947069ac11c948b510e6a9a7a8a6aa6061))
* Update dependency net.bytebuddy:byte-buddy to v1.18.1 ([#4214](https://togithub.com/googleapis/java-spanner/issues/4214)) ([0c1d843](https://togithub.com/googleapis/java-spanner/commit/0c1d843ad42f213d4d9ec2d98a12e21e991ac010))
* Update dependency net.bytebuddy:byte-buddy-agent to v1.18.1 ([#4215](https://togithub.com/googleapis/java-spanner/issues/4215)) ([76ce01b](https://togithub.com/googleapis/java-spanner/commit/76ce01b99e5c1274e9103c27ebc6bbdf482bebcd))
* Update opentelemetry.version to v1.56.0 ([#4167](https://togithub.com/googleapis/java-spanner/issues/4167)) ([a24f219](https://togithub.com/googleapis/java-spanner/commit/a24f21930978583a0b8d7d39130fa0fc3fec7b2d))

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@olavloite olavloite olavloite approved these changes

@rahul2393 rahul2393 rahul2393 approved these changes

@surbhigarg92 surbhigarg92 surbhigarg92 left review comments

Assignees

No one assigned

Labels

api: spanner Issues related to the googleapis/java-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

5 participants

@HailongWen @rahul2393 @olavloite @surbhigarg92 @yoshi-kokoro