Skip to content

Conversation

@thiagotnunes
Copy link
Contributor

The keepAlive traces were being tracked along with the parent span set by the client, which clutters the tracing stack. Here, we set the tracing to blank before issuing the keepAlive query.

The keepAlive traces were being tracked along with the parent span set
by the client, which clutters the tracing stack. Here, we set the
tracing to blank before issueing the keepAlive query.
@thiagotnunes thiagotnunes requested a review from a team as a code owner February 8, 2021 02:40
@google-cla google-cla bot added the cla: yes This human has signed the Contributor License Agreement. label Feb 8, 2021
@product-auto-label product-auto-label bot added the api: spanner Issues related to the googleapis/java-spanner API. label Feb 8, 2021
@codecov
Copy link

codecov bot commented Feb 8, 2021

Codecov Report

Merging #855 (7d897e1) into 3.1.x (0fd859d) will decrease coverage by 0.00%.
The diff coverage is 75.00%.

Impacted file tree graph

@@             Coverage Diff              @@
##              3.1.x     #855      +/-   ##
============================================
- Coverage     85.05%   85.05%   -0.01%     
+ Complexity     2556     2554       -2     
============================================
  Files           142      142              
  Lines         13930    13934       +4     
  Branches       1326     1326              
============================================
+ Hits          11848    11851       +3     
+ Misses         1526     1525       -1     
- Partials        556      558       +2     
Impacted Files Coverage Δ Complexity Δ
...ain/java/com/google/cloud/spanner/SessionImpl.java 83.52% <0.00%> (-0.50%) 29.00 <0.00> (ø)
...ain/java/com/google/cloud/spanner/SessionPool.java 88.56% <100.00%> (+0.03%) 71.00 <0.00> (ø)
...ud/spanner/SessionPoolAsyncTransactionManager.java 85.36% <0.00%> (-1.63%) 11.00% <0.00%> (-2.00%)
...a/com/google/cloud/spanner/AsyncResultSetImpl.java 91.89% <0.00%> (-0.39%) 32.00% <0.00%> (ø%)
...m/google/cloud/spanner/connection/SpannerPool.java 86.11% <0.00%> (+1.66%) 31.00% <0.00%> (ø%)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 0fd859d...7113745. Read the comment docs.

@thiagotnunes thiagotnunes changed the title fix: blanks span for session keepAlive traces fix(3.1.x): blanks span for session keepAlive traces Feb 8, 2021
@thiagotnunes thiagotnunes added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Feb 9, 2021
@yoshi-kokoro yoshi-kokoro removed kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Feb 9, 2021
@thiagotnunes thiagotnunes merged commit 8626a85 into googleapis:3.1.x Feb 9, 2021
@thiagotnunes thiagotnunes deleted the keep-alive-open-telemetry-3.1.x branch February 9, 2021 02:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/java-spanner API. cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants