samples: parameterises create backup version time #930
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…o pitr-samples-parameterised-create-backup
product-auto-label
bot
added
api: spanner
|
Here is the summary of changes. You are about to add 1 region tag.
This comment is generated by snippet-bot.
|
google-cla
bot
added
the
cla: yes
thiagotnunes
changed the title
…o pitr-samples-parameterised-create-backup
Codecov Report
@@ Coverage Diff @@
## pitr-samples #930 +/- ##
==================================================
+ Coverage 85.20% 85.22% +0.01%
- Complexity 2649 2650 +1
==================================================
Files 145 145
Lines 14358 14358
Branches 1391 1391
==================================================
+ Hits 12234 12236 +2
+ Misses 1540 1539 -1
+ Partials 584 583 -1
Continue to review full report at Codecov.
|
olavloite
approved these changes
Mar 2, 2021
thiagotnunes
added a commit
that referenced
this pull request
Mar 9, 2021
* feat: adds samples for pitr Adds sample for creating a database with a version retention period. Updates sample for creating a backup with a version time. Updates sample for restoring a backup, printing the backup version time. * fix: prints out version time for backup sample * test: adds test to the pitr create db sample * test: cleans up after pitr sample test finishes * test: fixes checkstyle violations * samples: updates backup samples for pitr Uses the earliest version time from the database as the version time for the backup. * test: fixes pitr samples test * test: fixes checkstyle violations * samples: PITR samples backup fix (#921) * samples: creates a backup using the current time Instead of using the earliest version time of the database, uses the current time (from spanner). If we used the earliest version time of the database instead we would be creating an empty backup, since the database we are backing up is not 1 hour old (default version retention period). * samples: remove unused variable Clean up create backup samples by removing unused variable. * samples: parameterises create backup version time (#930) * samples: fixes spanner samples tests
rajatbhatta
pushed a commit
to rajatbhatta/java-spanner
that referenced
this pull request
Nov 17, 2022
🤖 I have created a release *beep* *boop* --- ## [2.7.6](googleapis/java-spanner-jdbc@v2.7.5...v2.7.6) (2022-08-11) ### Dependencies * update dependency com.google.cloud:google-cloud-shared-dependencies to v3 ([googleapis#921](googleapis/java-spanner-jdbc#921)) ([2aa0a40](googleapis/java-spanner-jdbc@2aa0a40)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of hardcoding the version time in the create backup sample, parameterises it.