Skip to content

Conversation

@BenWhitehead
Copy link
Collaborator

Integrate OpenTelemetry tracing into our StorageITRunner.

By default the OpenTelementry.noop() instance will be used (avoiding the need for the requisite permissions).

To enable trace exporting for the tests, and the storage instances provide either the system property STORAGE_IT_OTEL_ENABLE=true or the environment variable STORAGE_IT_OTEL_ENABLE=true. They are evaluated as an OR, meaning that if both are specified and one is true and one is false, tracing will be enabled.

An example screenshot showing the registry cleaning up after test runs:
image

@BenWhitehead BenWhitehead requested review from a team as code owners January 7, 2025 21:36
@product-auto-label product-auto-label bot added size: l Pull request size is large. api: storage Issues related to the googleapis/java-storage API. labels Jan 7, 2025
Copy link
Contributor

@sydney-munro sydney-munro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM :)

@BenWhitehead BenWhitehead merged commit 958c21f into main Jan 9, 2025
21 checks passed
@BenWhitehead BenWhitehead deleted the otel/30/it-runner branch January 9, 2025 23:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: storage Issues related to the googleapis/java-storage API. size: l Pull request size is large.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants