Skip to content

test: update integration tests for rapid buckets to try and run #3034

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Apr 14, 2025
Merged

test: update integration tests for rapid buckets to try and run #3034

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 12 additions & 6 deletions google-cloud-storage/src/test/java/com/google/cloud/storage/ITAppendableUploadTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -20,13 +20,13 @@

import com.google.cloud.storage.Storage.BlobField;
import com.google.cloud.storage.Storage.BlobGetOption;
import com.google.cloud.storage.TransportCompatibility.Transport;
import com.google.cloud.storage.it.runner.StorageITRunner;
import com.google.cloud.storage.it.runner.annotations.Backend;
import com.google.cloud.storage.it.runner.annotations.BucketFixture;
import com.google.cloud.storage.it.runner.annotations.BucketType;
import com.google.cloud.storage.it.runner.annotations.CrossRun;
import com.google.cloud.storage.it.runner.annotations.Inject;
import com.google.cloud.storage.it.runner.annotations.SingleBackend;
import com.google.cloud.storage.it.runner.annotations.StorageFixture;
import com.google.cloud.storage.it.runner.registry.Generator;
import com.google.common.io.ByteStreams;
import java.io.IOException;
Expand All @@ -43,14 +43,14 @@
import org.junit.runner.RunWith;

@RunWith(StorageITRunner.class)
@SingleBackend(Backend.PROD)
@CrossRun(
backends = {Backend.PROD, Backend.TEST_BENCH},
transports = Transport.GRPC)
public final class ITAppendableUploadTest {

@Inject public Generator generator;

@Inject
@StorageFixture(TransportCompatibility.Transport.GRPC)
public Storage storage;
@Inject public Storage storage;

@Inject
@BucketFixture(BucketType.RAPID)
Expand Down Expand Up @@ -95,6 +95,8 @@ public void appendableBlobUploadWithoutFinalizing() throws IOException {
}

@Test
// Pending work in testbench, manually verified internally on 2025-03-25
@CrossRun.Ignore(backends = {Backend.TEST_BENCH})
public void appendableBlobUploadTakeover() throws Exception {
BlobAppendableUploadConfig uploadConfig =
BlobAppendableUploadConfig.of().withFlushPolicy(FlushPolicy.maxFlushSize(5));
Expand Down Expand Up @@ -139,6 +141,8 @@ public void testUploadFileUsingAppendable() throws Exception {
}

@Test
// Pending work in testbench, manually verified internally on 2025-03-25
@CrossRun.Ignore(backends = {Backend.TEST_BENCH})
public void finalizeAfterCloseWorks() throws Exception {
BlobAppendableUploadConfig uploadConfig =
BlobAppendableUploadConfig.of().withFlushPolicy(FlushPolicy.maxFlushSize(1024));
Expand All @@ -154,6 +158,8 @@ public void finalizeAfterCloseWorks() throws Exception {
}

@Test
// Pending work in testbench, manually verified internally on 2025-03-25
@CrossRun.Ignore(backends = {Backend.TEST_BENCH})
public void takeoverJustToFinalizeWorks() throws Exception {
BlobAppendableUploadConfig uploadConfig =
BlobAppendableUploadConfig.of().withFlushPolicy(FlushPolicy.maxFlushSize(5));
Expand Down
11 changes: 5 additions & 6 deletions google-cloud-storage/src/test/java/com/google/cloud/storage/ITObjectReadSessionTest.java
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -35,9 +35,8 @@
import com.google.cloud.storage.it.runner.annotations.Backend;
import com.google.cloud.storage.it.runner.annotations.BucketFixture;
import com.google.cloud.storage.it.runner.annotations.BucketType;
import com.google.cloud.storage.it.runner.annotations.CrossRun;
import com.google.cloud.storage.it.runner.annotations.Inject;
import com.google.cloud.storage.it.runner.annotations.SingleBackend;
import com.google.cloud.storage.it.runner.annotations.StorageFixture;
import com.google.cloud.storage.it.runner.registry.Generator;
import com.google.common.base.Stopwatch;
import com.google.common.hash.Hasher;
Expand All @@ -62,14 +61,14 @@
import org.junit.runner.RunWith;

@RunWith(StorageITRunner.class)
@SingleBackend(Backend.PROD)
@CrossRun(
backends = {Backend.PROD, Backend.TEST_BENCH},
transports = Transport.GRPC)
public final class ITObjectReadSessionTest {

private static final int _512KiB = 512 * 1024;

@Inject
@StorageFixture(Transport.GRPC)
public Storage storage;
@Inject public Storage storage;

@Inject
@BucketFixture(BucketType.RAPID)
Expand Down