chore: fix a ConcurrentModificationException during BlobReadSession#close() #3035
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…lose() A ConcurrentModificationException could happen while cleaning up an individual read at the same time the session had multiple child streams.
product-auto-label
bot
added
size: l
BenWhitehead
commented
Apr 14, 2025
| } | ||
| } finally { | ||
| lock.unlock(); | ||
| checkState(open, "Session already closed"); |
Collaborator
Author
There was a problem hiding this comment.
locking has been moved into the new ConcurrentIdentityMap, and the try-finally has been removed changing the indentation.
BenWhitehead
commented
Apr 14, 2025
| } | ||
| open = false; | ||
| List<ApiFuture<Void>> closing = | ||
| children.drainEntries((subStream, subStreamState) -> subStream.closeAsync()); |
Collaborator
Author
There was a problem hiding this comment.
use the new method, instead of manually traversing the iterator
bajajneha27
approved these changes
Apr 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
A ConcurrentModificationException could happen while cleaning up an individual read at the same time the session had multiple child streams.