-
Notifications
You must be signed in to change notification settings - Fork 36
fix: only release libraries if something has changed since last release #3339
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Summary of ChangesHello @ldetmer, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request enhances the library release mechanism by introducing an intelligent check to determine if a library has undergone any changes since its last release. This ensures that when a full release is triggered (e.g., with the Highlights
🧠 New Feature in Public Preview: You can now enable Memory to help Gemini Code Assist learn from your team's feedback. This makes future code reviews more consistent and personalized to your project's style. Click here to enable Memory in your admin console. Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request adds logic to only release libraries that have changed since the last release tag. The implementation is sound and includes updated tests to cover the new git-based logic. I've identified a few areas for improvement: a redundant check, a logic issue where single-library releases are checked for changes (which seems to contradict the PR description), and a potential problem with how empty library paths are handled. My detailed comments provide suggestions to address these points.
|
/gemini review |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Code Review
This pull request introduces a valuable enhancement to the release process by adding logic to only release libraries that have changed since the last tag when using the --all flag. The implementation is solid, leveraging git history to determine changes. The refactoring of source path derivation and function signatures across multiple files has improved code organization and clarity. The accompanying test changes are comprehensive, using a real git repository to validate the new functionality, which significantly increases confidence in the changes. Overall, this is a well-executed change.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3339 +/- ##
==========================================
+ Coverage 80.70% 80.78% +0.08%
==========================================
Files 163 163
Lines 13920 14032 +112
==========================================
+ Hits 11234 11336 +102
- Misses 2098 2100 +2
- Partials 588 596 +8 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
Add logic to generic release command that if --all flag is specified only release libraries if a change has been made since the previous release.
Fix #3327