Skip to content

chore(internal/serviceconfig): add java to sdk.yaml language list where supported#4547

Merged
zhumin8 merged 4 commits intogoogleapis:mainfrom
zhumin8:java-sdk-add
Mar 12, 2026
Merged

chore(internal/serviceconfig): add java to sdk.yaml language list where supported#4547
zhumin8 merged 4 commits intogoogleapis:mainfrom
zhumin8:java-sdk-add

Conversation

@zhumin8
Copy link
Copy Markdown
Contributor

@zhumin8 zhumin8 commented Mar 12, 2026

Add java to language list in sdk.yaml for API path that is supported in google-cloud-java. Changes to sdk.yaml is added running the temp script in temp commit and then removed the script. It gets full list of path from google-cloud-java and adds "java" to sdk.yaml language list when the languages are explicitly listed.

For #4062

@codecov
Copy link
Copy Markdown

codecov Bot commented Mar 12, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 79.65%. Comparing base (d6584ee) to head (d0d898b).
⚠️ Report is 6 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #4547      +/-   ##
==========================================
- Coverage   79.66%   79.65%   -0.01%     
==========================================
  Files         109      109              
  Lines        9120     9126       +6     
==========================================
+ Hits         7265     7269       +4     
- Misses       1344     1346       +2     
  Partials      511      511              

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

Copy link
Copy Markdown
Contributor

@gemini-code-assist gemini-code-assist Bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request adds java to the list of supported languages for numerous services in the sdk.yaml configuration file. The changes were applied systematically, and in each case, java has been inserted in alphabetical order within the existing language lists, which aids maintainability. The modifications appear consistent and align with the goal of updating the service configuration to reflect Java support.

@zhumin8 zhumin8 marked this pull request as ready for review March 12, 2026 16:44
@zhumin8 zhumin8 requested a review from a team as a code owner March 12, 2026 16:44
@zhumin8 zhumin8 enabled auto-merge (squash) March 12, 2026 16:44
@zhumin8 zhumin8 merged commit e731135 into googleapis:main Mar 12, 2026
19 of 20 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants