feat(tool/cmd/migrate): extract copyright year from existing files#4596
Merged
julieqiu merged 1 commit intogoogleapis:mainfrom Mar 15, 2026
Merged
Conversation
Read the copyright year from src/index.ts in each package and set it as copyright_year in the library config. This preserves the original copyright year when libraries are regenerated, since the generator always uses the current year.
Contributor
There was a problem hiding this comment.
Code Review
The pull request adds functionality to extract the copyright year from existing Node.js package files to preserve it during regeneration. The implementation is straightforward and includes a corresponding test update. I've suggested an improvement to the regular expression to handle year ranges in copyright notices, making the extraction more robust.
Codecov Report❌ Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #4596 +/- ##
=======================================
Coverage 79.39% 79.40%
=======================================
Files 110 110
Lines 9223 9232 +9
=======================================
+ Hits 7323 7331 +8
- Misses 1389 1390 +1
Partials 511 511 ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
JoeWang1127
approved these changes
Mar 15, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Read the copyright year from src/index.ts in each package and set it as copyright_year in the library config. This preserves the original copyright year when libraries are regenerated, since the generator always uses the current year.
For #4413