Skip to content

fix(internal/librarian/nodejs): remove Format step#4792

Merged
julieqiu merged 1 commit intogoogleapis:mainfrom
julieqiu:nodejs-skip-eslint
Mar 24, 2026
Merged

fix(internal/librarian/nodejs): remove Format step#4792
julieqiu merged 1 commit intogoogleapis:mainfrom
julieqiu:nodejs-skip-eslint

Conversation

@julieqiu
Copy link
Member

The old OwlBot pipeline never ran eslint on generated code. Removes Format to match the existing pipeline behavior and avoid diffs during migration.

For #4743

The old OwlBot pipeline never ran eslint on generated code. Running
eslint --fix causes extensive formatting churn (line wrapping, trailing
commas) without functional benefit.

This removes the Format function entirely to match the existing pipeline
behavior and avoid noisy diffs during migration.

For googleapis#4743
@julieqiu julieqiu requested a review from a team as a code owner March 24, 2026 01:27
Copy link
Contributor

@gemini-code-assist gemini-code-assist bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Code Review

This pull request removes the Format step from the Node.js library generation process. The changes involve removing the call to nodejs.Format in internal/librarian/generate.go, deleting the Format function itself from internal/librarian/nodejs/generate.go, and removing the corresponding tests and unused imports from internal/librarian/nodejs/generate_test.go. These changes are consistent with the goal of aligning the pipeline with the old OwlBot behavior, which did not run eslint on generated code. The code removal is clean and self-contained.

@codecov
Copy link

codecov bot commented Mar 24, 2026

Codecov Report

✅ All modified and coverable lines are covered by tests.
✅ Project coverage is 81.25%. Comparing base (755c74d) to head (d7f88c7).
⚠️ Report is 2 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #4792   +/-   ##
=======================================
  Coverage   81.25%   81.25%           
=======================================
  Files         129      129           
  Lines       10891    10875   -16     
=======================================
- Hits         8849     8836   -13     
+ Misses       1399     1396    -3     
  Partials      643      643           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • ❄️ Test Analytics: Detect flaky tests, report on failures, and find test suite problems.

@jameslynnwu
Copy link
Contributor

Should we create a task to https://github.com/googleapis/librarian/milestone/94 to add formatting back to nodejs generation?

@julieqiu julieqiu merged commit ec072a6 into googleapis:main Mar 24, 2026
24 of 25 checks passed
@julieqiu julieqiu deleted the nodejs-skip-eslint branch March 24, 2026 02:42
@julieqiu julieqiu mentioned this pull request Mar 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants