fix(internal/sidekick/api): Clean up the Typez constants#5249
Merged
ianthehat merged 1 commit intogoogleapis:mainfrom Apr 9, 2026
Merged
fix(internal/sidekick/api): Clean up the Typez constants#5249ianthehat merged 1 commit intogoogleapis:mainfrom
ianthehat merged 1 commit intogoogleapis:mainfrom
Conversation
coryan
approved these changes
Apr 9, 2026
coryan
changed the title
coryan
changed the title
Contributor
|
I tried to help with the title and failed. You have an extra space after |
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request modifies the Typez constant definitions in internal/sidekick/api/model.go by explicitly assigning integer values instead of using iota, and adjusts the placement of the associated documentation comment. Feedback indicates that the Go doc comment for the Typez constants should be rephrased to start with the entity name, and the constant names themselves (ALL_CAPS_WITH_UNDERSCORES) violate the Go style guide's "Mixed Caps" rule and contain redundant suffixes.
ianthehat
changed the title
Things that need to match external values should not use iota, instead we declare them directly. The doc comment should belong to the block, rather than being a floating comment before the first constant.
coryan
approved these changes
Apr 9, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Things that need to match external values should not use iota, instead we declare them directly.
The doc comment should belong to the block, rather than being a floating comment before the first constant.