feat(sidekick/swift): generate empty enums#5262
Merged
coryan merged 1 commit intogoogleapis:mainfrom Apr 10, 2026
Merged
Conversation
For package-level enums this generates the correct file with the copyright boilerplate and an empty enum. A future PR will add the missing enum values.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request introduces support for generating Swift enums by adding the necessary annotation logic, template files, and integration into the generation pipeline. I have provided feedback suggesting that the annotateEnum function be refactored to return an error instead of modifying the object in-place, which improves clarity and aligns with idiomatic Go practices.
julieqiu
approved these changes
Apr 10, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
For package-level enums this generates the correct file with the copyright boilerplate and an empty enum. A future PR will add the missing enum values.
Fixes #5261