chore(internal/serviceconfig): add missing titles#5587
Merged
jskeet merged 2 commits intogoogleapis:mainfrom Apr 24, 2026
Merged
chore(internal/serviceconfig): add missing titles#5587jskeet merged 2 commits intogoogleapis:mainfrom
jskeet merged 2 commits intogoogleapis:mainfrom
Conversation
Providing consistent titles for APIs without a service config (or where the service config doesn't provide one) allows languages that require a title per library to get one without having language-specific values.
![gemini-code-assist[bot]](https://avatars.githubusercontent.com/in/956858?s=60&v=4){kind=small}
Contributor
There was a problem hiding this comment.
Code Review
This pull request adds title fields to various service configurations in internal/serviceconfig/sdk.yaml. The review feedback suggests correcting a misassigned title for the Spanner adapter and updating the branding for App Engine Logging to ensure consistency with official naming conventions.
zhumin8
approved these changes
Apr 24, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Providing consistent titles for APIs without a service config (or where the service config doesn't provide one) allows languages that require a title per library to get one without having language-specific values.