-
Notifications
You must be signed in to change notification settings - Fork 108
Repo migration #4
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the |
| }; | ||
| assert.strictEqual(datastore.isDouble(value), false); | ||
| assert.strictEqual(called, true); | ||
| }); |
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
This comment was marked as spam.
This comment was marked as spam.
Sorry, something went wrong.
|
LGTM. We are missing some CI steps, and it looks like some aren't marked as
|
|
I changed the repo settings to require review and made circle checks required. Please review now :) |
|
Looking good! I see Circles are required, and AppVeyor is here now. We are still missing the CLA bot, codecov, greenkeeper, and snyk. Should we merge now and add later, or wait for those? |
|
Hmm, I wonder how those other stuff is set up. Let me talk to @lukesneeringer. |
Codecov Report
@@ Coverage Diff @@
## master #4 +/- ##
=======================================
Coverage ? 100%
=======================================
Files ? 5
Lines ? 639
Branches ? 0
=======================================
Hits ? 639
Misses ? 0
Partials ? 0
Continue to review full report at Codecov.
|
Migrating code to a separate repository, enabling continuous integration.