Skip to content

Conversation

@alexander-fenster
Copy link
Contributor

Migrating code to a separate repository, enabling continuous integration.

@googlebot
Copy link

So there's good news and bad news.

👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there.

😕 The bad news is that it appears that one or more commits were authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request.

Note to project maintainer: This is a terminal state, meaning the cla/google commit status will not change from this State. It's up to you to confirm consent of the commit author(s) and merge this pull request when appropriate.

};
assert.strictEqual(datastore.isDouble(value), false);
assert.strictEqual(called, true);
});

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

This comment was marked as spam.

@stephenplusplus
Copy link
Contributor

LGTM. We are missing some CI steps, and it looks like some aren't marked as required. Here's the template we can borrow from Logging:

  • ci/circleci: docs (required)
  • ci/circleci: lint (required)
  • ci/circleci: node4 (required)
  • ci/circleci: node6 (required)
  • ci/circleci: node7 (required)
  • ci/circleci: node8 (required)
  • ci/circleci: node9
  • cla/google
  • codecov/patch
  • codecov/project
  • continuous-integration/appveyor
  • greenkeeper/verify
  • security/snyk

@alexander-fenster
Copy link
Contributor Author

I changed the repo settings to require review and made circle checks required. Please review now :)

@stephenplusplus
Copy link
Contributor

Looking good! I see Circles are required, and AppVeyor is here now. We are still missing the CLA bot, codecov, greenkeeper, and snyk. Should we merge now and add later, or wait for those?

@alexander-fenster
Copy link
Contributor Author

Hmm, I wonder how those other stuff is set up. Let me talk to @lukesneeringer.

@codecov
Copy link

codecov bot commented Dec 16, 2017

Codecov Report

❗ No coverage uploaded for pull request base (master@6cb2e0c). Click here to learn what that means.
The diff coverage is 100%.

Impacted file tree graph

@@           Coverage Diff           @@
##             master     #4   +/-   ##
=======================================
  Coverage          ?   100%           
=======================================
  Files             ?      5           
  Lines             ?    639           
  Branches          ?      0           
=======================================
  Hits              ?    639           
  Misses            ?      0           
  Partials          ?      0
Impacted Files Coverage Δ
src/query.js 100% <100%> (ø)
src/index.js 100% <100%> (ø)
src/transaction.js 100% <100%> (ø)
src/request.js 100% <100%> (ø)
src/entity.js 100% <100%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 6cb2e0c...de8de1e. Read the comment docs.

@alexander-fenster alexander-fenster merged commit d381556 into master Dec 16, 2017
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants