Skip to content

Conversation

@BenWhitehead
Copy link
Contributor

The id property of Key is a string, update the use site of the key
to parse it as an int when being used to create a key.

The `id` property of `Key` is a string, update the use site of the key
to parse it as an int when being used to create a key.
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Jun 12, 2019
Copy link
Contributor

@callmehiphop callmehiphop left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think we want to use datastore.int(taskId) instead of parseInt. Technically both will work, but it would be great to include some of the built in helpers methods into a sample (they sometimes get missed)

The `id` property of `Key` is a string, update the use site of the key
to parse it as an int when being used to create a key.
@BenWhitehead
Copy link
Contributor Author

I think we want to use datastore.int(taskId) instead of parseInt. Technically both will work, but it would be great to include some of the built in helpers methods into a sample (they sometimes get missed)

Thanks, I didn't know that function existed. Pushed a new commit using datastore.int.

@codecov
Copy link

codecov bot commented Jun 12, 2019

Codecov Report

Merging #436 into master will not change coverage.
The diff coverage is n/a.

Impacted file tree graph

@@           Coverage Diff           @@
##           master     #436   +/-   ##
=======================================
  Coverage   98.05%   98.05%           
=======================================
  Files           5        5           
  Lines         617      617           
  Branches      145      145           
=======================================
  Hits          605      605           
  Partials       12       12

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 2edd95c...857e84e. Read the comment docs.

@JustinBeckwith JustinBeckwith added the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2019
@kokoro-team kokoro-team removed the kokoro:force-run Add this label to force Kokoro to re-run the tests. label Jun 14, 2019
@JustinBeckwith JustinBeckwith merged commit 7ee76b3 into googleapis:master Jun 14, 2019
@BenWhitehead BenWhitehead deleted the b/121062952 branch August 30, 2019 17:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

5 participants