Skip to content

Conversation

@callmehiphop
Copy link
Contributor

@callmehiphop callmehiphop commented Sep 11, 2019

Fixes #491

  • Tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
  • Appropriate docs were updated (if necessary)

@callmehiphop callmehiphop requested a review from a team September 11, 2019 08:40
@googlebot googlebot added the cla: yes This human has signed the Contributor License Agreement. label Sep 11, 2019
@codecov
Copy link

codecov bot commented Sep 11, 2019

Codecov Report

Merging #492 into master will increase coverage by 0.01%.
The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #492      +/-   ##
==========================================
+ Coverage   98.17%   98.18%   +0.01%     
==========================================
  Files           6        6              
  Lines         713      717       +4     
  Branches      171      171              
==========================================
+ Hits          700      704       +4     
  Misses          2        2              
  Partials       11       11
Impacted Files Coverage Δ
src/request.ts 99.5% <100%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 33292d2...7801774. Read the comment docs.

@JustinBeckwith JustinBeckwith merged commit 8d3b552 into googleapis:master Sep 11, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Uncatchable error is thrown if undefined is given on query filter (JS built version)

5 participants