Skip to content
This repository was archived by the owner on Mar 4, 2026. It is now read-only.

fix: serialization does not work with null objects#736

Merged
thebrianchen merged 4 commits into
googleapis:masterfrom
thebrianchen:nodejs-firestore-issue-732
Aug 22, 2019
Merged

fix: serialization does not work with null objects#736
thebrianchen merged 4 commits into
googleapis:masterfrom
thebrianchen:nodejs-firestore-issue-732

Conversation

@thebrianchen
Copy link
Copy Markdown

Fixes #732

Thanks to @praveenqlogic01 for spearheading the fix!

@googlebot
Copy link
Copy Markdown

All (the pull request submitter and all commit authors) CLAs are signed, but one or more commits were authored or co-authored by someone other than the pull request submitter.

We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that by leaving a comment that contains only @googlebot I consent. in this pull request.

Note to project maintainer: There may be cases where the author cannot leave a comment, or the comment is not properly detected as consent. In those cases, you can manually confirm consent of the commit author(s), and set the cla label to yes (if enabled on your project).

ℹ️ Googlers: Go here for more info.

@googlebot googlebot added the cla: no This human has *not* signed the Contributor License Agreement. label Aug 22, 2019
@thebrianchen thebrianchen changed the title fix: Serialization does not work with null objects fix: serialization does not work with null objects Aug 22, 2019
@thebrianchen thebrianchen added cla: yes This human has signed the Contributor License Agreement. and removed cla: no This human has *not* signed the Contributor License Agreement. labels Aug 22, 2019
@googlebot
Copy link
Copy Markdown

A Googler has manually verified that the CLAs look good.

(Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.)

ℹ️ Googlers: Go here for more info.

@thebrianchen thebrianchen merged commit 870d6a7 into googleapis:master Aug 22, 2019
@lookfirst
Copy link
Copy Markdown

@thebrianchen you kick ass man. thanks so much!

@sachinirftd
Copy link
Copy Markdown

This works:
JSON.parse(JSON.stringify(yourList))

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.

Labels

cla: yes This human has signed the Contributor License Agreement.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Serializer does not check object for a prototype before calling hasOwnProperty()

5 participants