fix: never try to create a negative number of sessions #1467
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
google-cla
bot
added
the
cla: yes
product-auto-label
bot
added
the
api: spanner
…s/nodejs-spanner into never-create-negative-sessions
olavloite
added
the
kokoro:force-run
yoshi-kokoro
removed
the
kokoro:force-run
skuruppu
approved these changes
Sep 10, 2021
gcf-merge-on-green bot
pushed a commit
that referenced
this pull request
Sep 10, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [5.15.2](https://www.github.com/googleapis/nodejs-spanner/compare/v5.15.1...v5.15.2) (2021-09-10) ### Bug Fixes * never try to create a negative number of sessions ([#1467](https://www.github.com/googleapis/nodejs-spanner/issues/1467)) ([13f5153](https://www.github.com/googleapis/nodejs-spanner/commit/13f51537ab13e0cd5a1fb9142f76796b1911809c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
asthamohta
pushed a commit
to asthamohta/nodejs-spanner
that referenced
this pull request
Sep 21, 2021
Co-authored-by: Owl Bot <gcf-owl-bot[bot]@users.noreply.github.com>
asthamohta
pushed a commit
to asthamohta/nodejs-spanner
that referenced
this pull request
Sep 21, 2021
🤖 I have created a release \*beep\* \*boop\* --- ### [5.15.2](https://www.github.com/googleapis/nodejs-spanner/compare/v5.15.1...v5.15.2) (2021-09-10) ### Bug Fixes * never try to create a negative number of sessions ([googleapis#1467](https://www.github.com/googleapis/nodejs-spanner/issues/1467)) ([13f5153](https://www.github.com/googleapis/nodejs-spanner/commit/13f51537ab13e0cd5a1fb9142f76796b1911809c)) --- This PR was generated with [Release Please](https://github.com/googleapis/release-please). See [documentation](https://github.com/googleapis/release-please#release-please).
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The session pool should never try to create a negative number of sessions. Especially the
_fillmethod could try that, as it would createthis.options.min! - this.sizesessions. That works well for an empty session pool, but not for one that has already been filled, and can cause the_pendingvalue to become negative.It might be that the
_fillmethod could cause the strange statistics that we see in #1465 if the following happens:_fillis called after the session pool has been initialized (i.e. there is at least 1 session in the pool)_pendingis increased with a negative number, potentially causing it to become negative:nodejs-spanner/src/session-pool.ts
Line 827 in b193122
_pendingis never updated when the sessions are created or the creation fails.Updates #1465