Skip to content

Conversation

@odeke-em
Copy link
Contributor

This change ensures that each span created by the code in this library is annotated with:

  • otel.scope.name = "cloud.google.com/nodejs/spanner"
  • otel.scope.version = <LIBRARY_VERSION>

Updates #2079

@odeke-em odeke-em requested review from a team as code owners September 10, 2024 22:22
@odeke-em odeke-em force-pushed the traces-add-otel-scope-variables branch from bb5cd2f to f8d0c21 Compare September 10, 2024 22:23
@conventional-commit-lint-gcf
Copy link

🤖 I detect that the PR title and the commit message differ and there's only one commit. To use the PR title for the commit history, you can use Github's automerge feature with squashing, or use automerge label. Good luck human!

-- conventional-commit-lint bot
https://conventionalcommits.org/

@odeke-em odeke-em changed the title observability/trace: ensure that each span has otel.scope.{name, version} observability/trace: ensure that each span has otel.scope.name,version Sep 10, 2024
@odeke-em odeke-em force-pushed the traces-add-otel-scope-variables branch from f8d0c21 to 8689854 Compare September 10, 2024 22:24
@odeke-em odeke-em changed the title observability/trace: ensure that each span has otel.scope.name,version observability: ensure that each span has otel.scope.name,version Sep 10, 2024
@odeke-em
Copy link
Contributor Author

/cc @willpoint

@product-auto-label product-auto-label bot added size: s Pull request size is small. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Sep 10, 2024
@odeke-em
Copy link
Contributor Author

Kindly cc-ing @surbhigarg92

This change ensures that each span created by the code in this
library is annotated with:
* otel.scope.name = "cloud.google.com/nodejs/spanner"
* otel.scope.version = <LIBRARY_VERSION>

Updates googleapis#2079
@odeke-em odeke-em force-pushed the traces-add-otel-scope-variables branch from f14a956 to 1beed76 Compare September 12, 2024 18:21
@surbhigarg92 surbhigarg92 added kokoro:run Add this label to force Kokoro to re-run the tests. owlbot:run Add this label to trigger the Owlbot post processor. labels Sep 12, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Sep 12, 2024
@yoshi-kokoro yoshi-kokoro removed the kokoro:run Add this label to force Kokoro to re-run the tests. label Sep 12, 2024
@surbhigarg92 surbhigarg92 merged commit 84b99ef into googleapis:main Sep 13, 2024
@odeke-em odeke-em deleted the traces-add-otel-scope-variables branch September 20, 2024 06:12
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. size: s Pull request size is small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants