feat: (observability) trace Instance #2134
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Trace instruments the Instance class. Updates googleapis#2079
product-auto-label
bot
added
size: xl
Contributor
surbhigarg92
left a comment
surbhigarg92
left a comment
There was a problem hiding this comment.
Lets keep this as well on hold.
We will finish everything related to dataClient , which is running transaction , queries etc. Changes in this file are for database operations. So in order to keep things simple, I would like to first complete the dataClient first, test, release and then see if we want to add this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Trace instruments the Instance class.
Updates #2079