chore: support for common interface to get a session to support multiplexed session #2204
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
product-auto-label
bot
added
size: l
alkatrivedi
force-pushed
the
get-session-class
branch
4 times, most recently
from
bddd1d4 to
421a5a1
Compare
alkatrivedi
force-pushed
the
get-session-class
branch
from
6061d99 to
df92e41
Compare
alkatrivedi
force-pushed
the
get-session-class
branch
3 times, most recently
from
21394ef to
3730a8a
Compare
alkatrivedi
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
alkatrivedi
force-pushed
the
get-session-class
branch
from
e49f2a4 to
3f2117a
Compare
alkatrivedi
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
alkatrivedi
force-pushed
the
get-session-class
branch
3 times, most recently
from
e24245d to
be238ed
Compare
alkatrivedi
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
alkatrivedi
added
kokoro:force-run
product-auto-label
bot
added
size: l
alkatrivedi
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
| * | ||
| * @param {Database} database Database object. | ||
| * @param {String} name Name of the database. | ||
| * @param {SessionPoolOptions|SessionPoolInterface} options Session pool |
Contributor
There was a problem hiding this comment.
SessionPoolConstructor right
Suggested change
| * @param {SessionPoolOptions|SessionPoolInterface} options Session pool | |
| * @param {SessionPoolOptions| SessionPoolConstructor} options Session pool |
Contributor
There was a problem hiding this comment.
Please let me know if my understanding is incorrect ?
Contributor
Author
There was a problem hiding this comment.
Since, the SessionPoolConstructor is eventually creating SessionPoolInterface object, hence we can keep SessionPoolInterface here in the documentation
yoshi-kokoro
removed
the
kokoro:force-run
alkatrivedi
force-pushed
the
get-session-class
branch
from
025dd00 to
db372ba
Compare
alkatrivedi
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
surbhigarg92
approved these changes
Dec 27, 2024
alkatrivedi
added
the
do not merge
surbhigarg92
changed the title
alkatrivedi
force-pushed
the
get-session-class
branch
from
db372ba to
d536b2e
Compare
yoshi-kokoro
removed
the
kokoro:force-run
alkatrivedi
added
kokoro:force-run
gcf-owl-bot
bot
removed
the
owlbot:run
yoshi-kokoro
removed
the
kokoro:force-run
alkatrivedi
added
automerge
gcf-merge-on-green
bot
removed
the
automerge
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
4 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR contains the common interface class SessionFactory which will be responsible for the creation of the Session Pool and the Multiplexed Session(if the env variable would be set to true) upon client initialization.
This PR also contains the getSession method which will return the session(multiplexed/regular) based upon the env variable value.