-
Notifications
You must be signed in to change notification settings - Fork 112
feat: await/catch promises, and update listOperationsAsync return type #2240
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closed
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
surbhigarg92
approved these changes
Feb 27, 2025
docs: A comment for field `rows` in message `.google.spanner.v1.ResultSet` is changed docs: A comment for field `stats` in message `.google.spanner.v1.ResultSet` is changed docs: A comment for field `precommit_token` in message `.google.spanner.v1.ResultSet` is changed docs: A comment for field `values` in message `.google.spanner.v1.PartialResultSet` is changed docs: A comment for field `chunked_value` in message `.google.spanner.v1.PartialResultSet` is changed docs: A comment for field `stats` in message `.google.spanner.v1.PartialResultSet` is changed docs: A comment for field `precommit_token` in message `.google.spanner.v1.PartialResultSet` is changed docs: A comment for message `ResultSetMetadata` is changed docs: A comment for field `row_type` in message `.google.spanner.v1.ResultSetMetadata` is changed docs: A comment for message `ResultSetStats` is changed docs: A comment for field `query_plan` in message `.google.spanner.v1.ResultSetStats` is changed docs: A comment for field `row_count_lower_bound` in message `.google.spanner.v1.ResultSetStats` is changed PiperOrigin-RevId: 730849734 Source-Link: googleapis/googleapis@fe0fa26 Source-Link: googleapis/googleapis-gen@16051b5 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTYwNTFiNTkxN2I3NWY2MDNjY2I1ZjQ3N2UyYTQ2NDdiYTExZmE4MiJ9
PiperOrigin-RevId: 731693666 Source-Link: googleapis/googleapis@fd510f8 Source-Link: googleapis/googleapis-gen@42097f7 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDIwOTdmN2NjNzZlZTdiZGZlY2FlYWVhMTE1YWYyMzU3MTZmZGRiMSJ9
PiperOrigin-RevId: 732130682 Source-Link: googleapis/googleapis@9415ba0 Source-Link: googleapis/googleapis-gen@2905f83 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwNWY4MzM3NTZjMmIyMGIzMjgyYmU4NGI1MTFlMDQwZmU1NGYzMyJ9
feat: add request/response debug logging to gapics, update templates to gax 5 and node 18 (#1671) fix: add json files to tsconfig templates (#1692) (ba6be1d) PiperOrigin-RevId: 735896588 Source-Link: googleapis/googleapis@3419af7 Source-Link: googleapis/googleapis-gen@f35ba11 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjM1YmExMTQyZjRlMTY4MjIyMzI3ZDg5MmI1ZjZlZTkwOGU1ZDQ2MSJ9
PiperOrigin-RevId: 738212310 Source-Link: googleapis/googleapis@803b234 Source-Link: googleapis/googleapis-gen@4f44bd2 Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9
c27906d to
2a9f478
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
api: spanner
Issues related to the googleapis/nodejs-spanner API.
do not merge
Indicates a pull request not ready for merge, due to either quality or timing.
kokoro:force-run
Add this label to force Kokoro to re-run the tests.
owl-bot-copy
size: u
Pull request is empty.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PiperOrigin-RevId: 738212310
Source-Link: googleapis/googleapis@803b234
Source-Link: https://github.com/googleapis/googleapis-gen/commit/4f44bd2baa8dd5a71ca0cebdb164c3c34341ed87
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNGY0NGJkMmJhYThkZDVhNzFjYTBjZWJkYjE2NGMzYzM0MzQxZWQ4NyJ9
BEGIN_NESTED_COMMIT
chore: update typescript gapic generator to 4.8.1
feat: add request/response debug logging to gapics, update templates to gax 5 and node 18 (#1671)
fix: add json files to tsconfig templates (#1692) (ba6be1d)
PiperOrigin-RevId: 735896588
Source-Link: googleapis/googleapis@3419af7
Source-Link: https://github.com/googleapis/googleapis-gen/commit/f35ba1142f4e168222327d892b5f6ee908e5d461
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiZjM1YmExMTQyZjRlMTY4MjIyMzI3ZDg5MmI1ZjZlZTkwOGU1ZDQ2MSJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: update copyright year for auto-generated protos
PiperOrigin-RevId: 732130682
Source-Link: googleapis/googleapis@9415ba0
Source-Link: https://github.com/googleapis/googleapis-gen/commit/2905f833756c2b20b3282be84b511e040fe54f33
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMjkwNWY4MzM3NTZjMmIyMGIzMjgyYmU4NGI1MTFlMDQwZmU1NGYzMyJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
chore: update copyright year for auto-generated protos
PiperOrigin-RevId: 731693666
Source-Link: googleapis/googleapis@fd510f8
Source-Link: https://github.com/googleapis/googleapis-gen/commit/42097f7cc76ee7bdfecaeaea115af235716fddb1
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiNDIwOTdmN2NjNzZlZTdiZGZlY2FlYWVhMTE1YWYyMzU3MTZmZGRiMSJ9
END_NESTED_COMMIT
BEGIN_NESTED_COMMIT
feat: add a last field in the PartialResultSet
docs: A comment for field
rowsin message.google.spanner.v1.ResultSetis changeddocs: A comment for field
statsin message.google.spanner.v1.ResultSetis changeddocs: A comment for field
precommit_tokenin message.google.spanner.v1.ResultSetis changeddocs: A comment for field
valuesin message.google.spanner.v1.PartialResultSetis changeddocs: A comment for field
chunked_valuein message.google.spanner.v1.PartialResultSetis changeddocs: A comment for field
statsin message.google.spanner.v1.PartialResultSetis changeddocs: A comment for field
precommit_tokenin message.google.spanner.v1.PartialResultSetis changeddocs: A comment for message
ResultSetMetadatais changeddocs: A comment for field
row_typein message.google.spanner.v1.ResultSetMetadatais changeddocs: A comment for message
ResultSetStatsis changeddocs: A comment for field
query_planin message.google.spanner.v1.ResultSetStatsis changeddocs: A comment for field
row_count_lower_boundin message.google.spanner.v1.ResultSetStatsis changedPiperOrigin-RevId: 730849734
Source-Link: googleapis/googleapis@fe0fa26
Source-Link: https://github.com/googleapis/googleapis-gen/commit/16051b5917b75f603ccb5f477e2a4647ba11fa82
Copy-Tag: eyJwIjoiLmdpdGh1Yi8uT3dsQm90LnlhbWwiLCJoIjoiMTYwNTFiNTkxN2I3NWY2MDNjY2I1ZjQ3N2UyYTQ2NDdiYTExZmE4MiJ9
END_NESTED_COMMIT