Skip to content

Conversation

@surbhigarg92
Copy link
Contributor

@surbhigarg92 surbhigarg92 commented Oct 23, 2025

This PR modifies gRPC keepalive_time_ms from 30 sec to 120 sec as per the other languages (Refer Java )

This also removes the gRPC keepalive_timeout_ms configuration, the default configured for gRPC is 20 seconds

These settings can be over written by passing to spanner options

const spanner = new Spanner({ 
    'grpc.keepalive_time_ms': 30000,
  });

@surbhigarg92 surbhigarg92 requested review from a team as code owners October 23, 2025 10:47
@product-auto-label product-auto-label bot added size: xs Pull request size is extra small. api: spanner Issues related to the googleapis/nodejs-spanner API. labels Oct 23, 2025
@surbhigarg92 surbhigarg92 added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 23, 2025
@surbhigarg92 surbhigarg92 removed the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Oct 23, 2025
@surbhigarg92 surbhigarg92 merged commit f280e7c into main Oct 24, 2025
24 of 25 checks passed
@surbhigarg92 surbhigarg92 deleted the surbhigarg92-patch-1 branch October 24, 2025 06:34
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

api: spanner Issues related to the googleapis/nodejs-spanner API. size: xs Pull request size is extra small.

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants